Re: [PATCH v5 1/6] dt-bindings: Add Blaize vendor prefix

Nikolaos Pasaloukos
2024-11-19T16:24:12Z

On 19/11/2024 15:52, Krzysztof Kozlowski wrote:
> On 19/11/2024 16:23, Nikolaos Pasaloukos wrote:
>> Hi Krzysztof,
>>
>> That's a very tricky error to pick it up. `checkpatch` on my end doesn't produce
>> an error. The header file on my patches starts as:
>> 'From: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>'
>> I had set the mail account as Forname: Nikolaos, Surname: Pasaloukos and
>> preferred name as Niko. It is an Outlook365 issue I think.
>>
>> That said, when I was trying to send my patches, the mail server was converting
>> my name 'Nikolaos Pasaloukos' to the preferred name 'Niko Pasaloukos'.
> Usually it is not a problem to commit patches with one name and send
> with other - git send-email will properly add two From headers like:
> https://urldefense.com/v3/__https://lore.kernel.org/all/20241119154245.442961-4-pablo@netfilter.org/__;!!FddXBOku!jmi9Ec3WZ4N6TfC0XlHzSmeISVpB19XDD-TfRyCDgkc6WpnZnjDJMz4bZWeoOY8X6YaL9GnapF-AIw-Cjyer$
>
> If your git history has correct From matching SoB, then indeed
> checkpatch on your end will not complain.
>
> If that is the case, it means your SMTP server *rewrites* the From
> header. Not nice... but what to expect from Microsoft? They learnt open
> source just recently and before open source was communism for them...
>
> You can change your local name to match whatever Microsoft wants to set
> or you can use b4 relay to send the patches.

I'll add your Reviewed-by on the patches and I will send again v5 patches
using the b4 relay endpoint instead of my SMTP server.

>
> https://urldefense.com/v3/__https://b4.docs.kernel.org/en/latest/contributor/send.html__;!!FddXBOku!jmi9Ec3WZ4N6TfC0XlHzSmeISVpB19XDD-TfRyCDgkc6WpnZnjDJMz4bZWeoOY8X6YaL9GnapF-AI5htzUil$
>
>> Do I need to resend v5 again after this is fixed, having applied all the
>> additional Reviewed-by? What would be my next step here?
> Yes, please resend a v5 with tags applied and fixed problem with From/SoB.
>
>
> Best regards,
> Krzysztof

Thank you for helping me out.

Best regards,
Nikolaos Pasaloukos