From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 522AFC7EE22 for ; Tue, 9 May 2023 13:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235430AbjEING1 (ORCPT ); Tue, 9 May 2023 09:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235369AbjEINGQ (ORCPT ); Tue, 9 May 2023 09:06:16 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4BE6525A for ; Tue, 9 May 2023 06:06:08 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-50bc25f0c7dso10940479a12.3 for ; Tue, 09 May 2023 06:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683637567; x=1686229567; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dq27aAWxCkL5lh0gQsM04iiHCtmU3UirHOLrJGmxHBw=; b=bTzFElQ0Ijj7Qqx+ITj7N8by0OSLOkJjap0bR5jb2buLViuMHSIwCpg2gPnbNxbiur n33ue596ZSOoRMFmoqk2Nw+qulSAPRl9FFYrxG+D2hBsBpuJ9rzibf7y9hl7H2osQ8GV e9Y2kuXfjDo1FnM7qhu8Xbnp5qKFZZ1JKEy8kyyruikEg+KOZ18yiV3ne2ALwGNSFm2g Y9Pjr9teRy4OQkplB6eGyFeQQ/2RFgxPRgGrgYiTmhV3rK/WmKhBGkahCk3OLdhgtGmn jhA2SRixz7fO3Vq/zMVXv+AT/afuzs+K/HadURIPOpJYvBaEs8iR4BF1A3otPPfzz5ej +hwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683637567; x=1686229567; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dq27aAWxCkL5lh0gQsM04iiHCtmU3UirHOLrJGmxHBw=; b=Gnd/RSqQP/5OH+mb+kiIFiAAMB05k3wzR2iENybyCds8ycnETCYi0klfN5I8Uyad+z GwqCfEm2Uhzx6f03/AOpkCDPqjN0F9XVTmdIYtDBgqVjtjyL6s++Tph2av39np7KBIwc bq8XTO0kCBA7duktDor987tJowxKxiFy8kc/I/jwntQSsoilOVbAllweIy+oVd9h+BXM MVEgY6Gbzqt+6BuaySJC7J24jmbO1LsgrJSfhkonhWU7YXnp0aKA8zE7DsG9KbL2Nb3g dtU0uHXxAhkyOAsiTJ3hMlyGt/cYkQx73HiCBYjQm79bG3sEzWupivbzm6exihwj06ZO iV7Q== X-Gm-Message-State: AC+VfDwtiV7+9Cg9T7BAPVe7yO9OQnoqox49D8KGP5TooJuxl4Y5Ubt2 KV2emEXqw+ssr7XCCn1oPmXiFQ== X-Google-Smtp-Source: ACHHUZ6HVGeI7Az5TQaNdcCmmaidSWz1zdgkmcirij9gIwYx2Yg390YoZ0P4jiPXBvOB89RSgg60Lw== X-Received: by 2002:aa7:c059:0:b0:50d:9b57:842a with SMTP id k25-20020aa7c059000000b0050d9b57842amr5582009edo.9.1683637567393; Tue, 09 May 2023 06:06:07 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d0d5:7818:2f46:5e76? ([2a02:810d:15c0:828:d0d5:7818:2f46:5e76]) by smtp.gmail.com with ESMTPSA id y2-20020a056402134200b00504ecc4fa96sm726424edw.95.2023.05.09.06.06.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 May 2023 06:06:06 -0700 (PDT) Message-ID: <8b540cc2-bc0d-9d8b-45e6-98410322b3f6@linaro.org> Date: Tue, 9 May 2023 15:06:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [EXT] Re: [PATCH 1/2 v7] dt-bindings: watchdog: marvell GTI system watchdog driver Content-Language: en-US To: Bharat Bhushan , "wim@linux-watchdog.org" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux-watchdog@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sunil Kovvuri Goutham References: <20230508131515.19403-1-bbhushan2@marvell.com> <8119eec8-0190-b6a5-85a7-301bcb81b0c9@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/05/2023 11:01, Bharat Bhushan wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Tuesday, May 9, 2023 1:38 PM >> To: Bharat Bhushan ; wim@linux-watchdog.org; >> linux@roeck-us.net; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; >> linux-watchdog@vger.kernel.org; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; Sunil Kovvuri Goutham >> Subject: Re: [EXT] Re: [PATCH 1/2 v7] dt-bindings: watchdog: marvell GTI system >> watchdog driver >> >> On 09/05/2023 09:26, Bharat Bhushan wrote: >> >> >>>>> +properties: >>>>> + compatible: >>>>> + oneOf: >>>>> + - const: marvell,octeontx2-wdt >>>> >>>> Why is this alone? Judging by the enum below, octeontx2 is not specific. >>>> >>>>> + - items: >>>>> + - enum: >>>>> + - marvell,octeontx2-95xx-wdt >>>>> + - marvell,octeontx2-96xx-wdt >>>>> + - marvell,octeontx2-98xx-wdt >>>> >>>> We don't allow wildcards in general >>> >>> Marvell have octeontx2 series of processor which have watchdog timer. >>> In 95xx,98xx,96xx are the processors in octeontx2 series of processor. So >> octeontx2-95xx is on soc, octeontx2-96xx is another and so on. >> >> No, 95xx is not a processor. Otherwise please point me to exact product >> datasheet. Hint: I checked it. > > Looks like 95xx data sheet is not public, will remove in that case. We can talk about 96xx. Can you point me to the SoC named exactly like this? Hint: I checked it. > >> >>> >>>> >>>>> + - const: marvell,octeontx2-wdt >>>>> + - const: marvell,cn10k-wdt >>>> >>>> Same question - why is this alone? >>> Same here, Marvell have cn10k series of processors and cn10kx and cnf10kx are >> the processor in this series. >> >> I don't understand how does it explain my concern. This is alone because there >> are series of processors? How is that related? > > Tried to make it look like other drivers. Let's keep it simple, we want to enable this only for below ones Enable what? None of these explains why do you need this entry alone, since it is covered by list further. > > properties: > compatible: > enum: > - marvell,cn10k-wdt > - marvell,octeontx2-wdt > > Are you good with that? Not sure, it sounds like it ignores our entire discussion. What's the name of the SoC? I see "OcteonTx2 CN9130", not "OcteonTx2". I linked your previously guide how to write bindings. Did you read it? Best regards, Krzysztof