[PATCH 0/2] net: qcom/emac: add shared mdio bus support

[PATCH 0/2] net: qcom/emac: add shared mdio bus support

[Wang Dongsheng]

Share the mii_bus for others MAC device because QDF2400 emac
include MDIO, and the motherboard has more than one PHY connected
to an MDIO bus.

Tested: QDF2400 (ACPI), buildin/insmod/rmmod

Wang Dongsheng (2):
  dt-bindings: net: qcom: Add binding for shared mdio bus
  net: qcom/emac: add shared mdio bus support

 .../devicetree/bindings/net/qcom-emac.txt     |   4 +
 drivers/net/ethernet/qualcomm/emac/emac-phy.c | 211 ++++++++++++++----
 drivers/net/ethernet/qualcomm/emac/emac.c     |   7 +-
 3 files changed, 178 insertions(+), 44 deletions(-)

-- 
2.18.0

[PATCH 1/2] dt-bindings: net: qcom: Add binding for shared mdio bus

[Wang Dongsheng]

This property copy from "ibm,emac.txt" to describe a shared MIDO bus.
Since QDF2400 emac include MDIO, so If the motherboard has more than one
PHY connected to an MDIO bus, this property will point to the MAC device
that has the MDIO bus.

Signed-off-by: Wang Dongsheng <dongsheng.wang@hxt-semitech.com>
---
 Documentation/devicetree/bindings/net/qcom-emac.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/qcom-emac.txt b/Documentation/devicetree/bindings/net/qcom-emac.txt
index 346e6c7f47b7..50db71771358 100644
--- a/Documentation/devicetree/bindings/net/qcom-emac.txt
+++ b/Documentation/devicetree/bindings/net/qcom-emac.txt
@@ -24,6 +24,9 @@ Internal PHY node:
 The external phy child node:
 - reg : The phy address
 
+Optional properties:
+- mdio-device : Shared MIDO bus.
+
 Example:
 
 FSM9900:
@@ -86,6 +89,7 @@ soc {
 		reg = <0x0 0x38800000 0x0 0x10000>,
 		      <0x0 0x38816000 0x0 0x1000>;
 		interrupts = <0 256 4>;
+		mdio-device = <&emac1>;
 
 		clocks = <&gcc 0>, <&gcc 1>, <&gcc 3>, <&gcc 4>, <&gcc 5>,
 			 <&gcc 6>, <&gcc 7>;
-- 
2.18.0

Re: [PATCH 0/2] net: qcom/emac: add shared mdio bus support

[Andrew Lunn]

On Thu, Sep 13, 2018 at 05:04:51PM +0800, Wang Dongsheng wrote:
> Share the mii_bus for others MAC device because QDF2400 emac
> include MDIO, and the motherboard has more than one PHY connected
> to an MDIO bus.
> 
> Tested: QDF2400 (ACPI), buildin/insmod/rmmod
> 
> Wang Dongsheng (2):
>   dt-bindings: net: qcom: Add binding for shared mdio bus

Hi Wang

Patch #1 did not seem to make it to netdev.

I probably have some comments on the binding...

  Andrew

Re: [PATCH 1/2] dt-bindings: net: qcom: Add binding for shared mdio bus

[Timur Tabi]

On 9/13/18 4:04 AM, Wang Dongsheng wrote:
> This property copy from "ibm,emac.txt" to describe a shared MIDO bus.
> Since QDF2400 emac include MDIO, so If the motherboard has more than one
> PHY connected to an MDIO bus, this property will point to the MAC device
> that has the MDIO bus.
> 
> Signed-off-by: Wang Dongsheng<dongsheng.wang@hxt-semitech.com>

The QDF2400 does not support device trees, so please don't talk about DT 
support in the context of the QDF2400.

Re: [PATCH 1/2] dt-bindings: net: qcom: Add binding for shared mdio bus

[Wang, Dongsheng]

On 9/13/2018 11:02 PM, Timur Tabi wrote:
> On 9/13/18 4:04 AM, Wang Dongsheng wrote:
>> This property copy from "ibm,emac.txt" to describe a shared MIDO bus.
>> Since QDF2400 emac include MDIO, so If the motherboard has more than one
>> PHY connected to an MDIO bus, this property will point to the MAC device
>> that has the MDIO bus.
>>
>> Signed-off-by: Wang Dongsheng<dongsheng.wang@hxt-semitech.com>
> The QDF2400 does not support device trees, so please don't talk about DT 
> support in the context of the QDF2400.
>
Ok, remove QDF2400.

s/QDF2400 emac/emac/


Cheers,

-Dongsheng