From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02089222560 for ; Wed, 29 Oct 2025 12:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761741013; cv=none; b=W9M5Oe56x9JNP1l4bqSF1rdkrJJyJarhg+ny5BXv3TaKIpsd/oVvXzpNZKHD9Y0sAgtmjsQ6GhpRZ6nsrg5D4As5mFGzoCp7jn0+NZRMZIl/jIqMJcQv+gw441iteAt2GnqPtQ4DbJoxXqDpR0tNP+p9wZ8XWu6+dUIsSwlkU2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761741013; c=relaxed/simple; bh=yfVwVTerZPk2NHZzlK1pqB6FPkQ/oXmjoq1IP210Xts=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p85LIQkbU4c7t9BNxYkoTcc+SEmN14PKvhIaMHTHNJfFdNbrW1qcgcGze49Z6VFqQlL1MbSkOlGCYVcOsxNtfIYoXLPQS2yupRZ0jClA45Lhgu7z1+wDPcbOmBx/SyEUVOqWaT5so5ExFGszyJ5QGYpih6LPbipNeaBoGh6JTQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MTdj887y; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MTdj887y" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-592f7e50da2so1181538e87.0 for ; Wed, 29 Oct 2025 05:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761741009; x=1762345809; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ui8ftKpD8oJJMrnzjOA4xyfnszlxAAkwMFpTMiFGLGY=; b=MTdj887yxeCcg1+C9KOyxLpebLhYr4D3K4eae5EfsfBGLwZZaS7Uj2ic8cnzWCTU7c IzDZJTUda9Dvxy9J5Ui1yoEikVYbDqL39O+PKS1dezNKm61QNf1wZNBlcM+VNzQJtXnI 5XNeIjnuk0QhhBptDvDRRgmbQJn8DvHYe/mdGW4jDNXPOtGvVQfUmBGu07Z6Zz+d06eN cxaQvO57e9cHFFKyixZfLrNOowWwpk+t9vnwkrlIffJV2SxKUUSMPK026sep3ZpeneqU Ea5iLQsvlqmiCfkltQzcYCnop2zDNCtCpJG0JV8WdaZZC9THxxsag1m5tnOCP2COdXTs Mxog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761741009; x=1762345809; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ui8ftKpD8oJJMrnzjOA4xyfnszlxAAkwMFpTMiFGLGY=; b=IZB2wFM/zrsQOok/n1CEUi8h1CY8Jx/LVj0AqgoW2Wh7tVjdOUlL/VjWaFXQHBHv8l M6kL/LBb0DOVCgQzsdd9pmZQaCtlMrDbycffLRrA5iEfCA6uyiXjAYqwnjxcP5wvxrqe 8wIexb/wUSTIAhl2TR8DXPqOClLyI/0IAcg0HHp81eicSmzUuNEDeap8vCmR0hRqrF/e yG5L2K2kWOOa8k+8hKzZw9qM3Jm9fyQjV5RHRuRRH/IRjYVHs0hm0cAQv1hZ5pTRV1EV ucMldxqfWz8XN0o+j146W0lqi0xN0nxIsPqd0ZbGkLIXvc4mRYfpy06e9q87tAiLKhbE VRyw== X-Forwarded-Encrypted: i=1; AJvYcCXRXyDQjsRkMA6n5mezp7nPXQn0YF0XMzghulpB+J1nKRHxKPnd1wztTc/OJrT+mITHrSdXnSn/3xKS@vger.kernel.org X-Gm-Message-State: AOJu0Yz23RiIyfd2iMvIEE1E5D5qgs5M9qiBZ+hCRlTDRuPWjl9hm0R4 tadhgL8H/AD1ijzi2t2zDleN5wctJsMgq6ZT+CtfS1pGRatPI6RyDU5+ X-Gm-Gg: ASbGnctvTsAFD3CPCuRGGqTEfxBTwz0/cKUp7EOqfzxSPimwVtGdyqwgN3zOW5RwWyx FWr/kTyfLUwf3oidIx9JEGJLUbxJ3O60RlsFNt3SMYUu11bLEaD1/scTzRaSs2bIk4k/z8n55/t il0PPYFDrDgDdcC4B5xRE61oN2FIMp6p2RwD30bqVdWnt189cyNbrw5h2Ra06CbAVHmVjEwrWzl nt10IjJCw07RLsSr9rhuHduUjgoP2DI+rAo4OYR5anXZFXB/q07w/USIP0/nzbAkv1k9i9/ZhKx TRCVZFHdHU08NxLPOGMUKVJ4ls1bzGjtJGGzM5UV6kE1TIYmZGIKzP27to6mbqBGI/I+/pPVm8u EM7y4lV1ILO2ckqtxEN+qMOsHCfZGSM/lbK7vUd5qoX0MbQ0dvCF345VCwo3SvfQYsU+cH5++GY WxB2wffqEwcw== X-Google-Smtp-Source: AGHT+IGoOBmpR56r91eNxNa3niN5na4xSuldumEKqunNvTbGH3/QMdmFRTjv+fJgOEfNR9uGhYfhgA== X-Received: by 2002:a05:6512:3a8e:b0:591:ec58:ec7c with SMTP id 2adb3069b0e04-5930ee07801mr2415382e87.25.1761741008581; Wed, 29 Oct 2025 05:30:08 -0700 (PDT) Received: from [10.38.18.54] ([213.255.186.37]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59301f50a7asm3782619e87.34.2025.10.29.05.30.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Oct 2025 05:30:07 -0700 (PDT) Message-ID: <8b5dbbf6-bbde-4015-b0d1-12d6ec770ceb@gmail.com> Date: Wed, 29 Oct 2025 14:30:06 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/15] dt-bindings: mfd: ROHM BD72720 To: Linus Walleij Cc: Matti Vaittinen , Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org References: Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/10/2025 00:42, Linus Walleij wrote: > Hi Matti, > > thanks for your patch! > > On Mon, Oct 27, 2025 at 12:45 PM Matti Vaittinen > wrote: > >> + rohm,clkout-open-drain: >> + description: clk32kout mode. Set to 1 for "open-drain" or 0 for "cmos". >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + minimum: 0 >> + maximum: 1 > > I think CMOS is the same as "push-pull" ( I could be wrong, but I think I've > seen that before) so I would probably try to use the pin config standard > names as strings here but I'm not sure. > > rohm,clkout-bias-open-drain; > rohm,clkout-bias-push-pull; > > Mutually exclusive. > > Or maybe use the pattern from rohm,pin-dvs0 > with string enumerators? > > rohm,clkout-bias = "open-drain"; > rohm,clkout-bias = "push-pull"; > Hmm. I kind of agree with you. Still, the way it was done in this patch is used by the other existing ROHM PMICs (bd71815, bd71828, bd71879). I am kind of reluctant to support another way in the same driver - and I am also reluctant to change the existing bindings as that sounds a bit like asking for a nose-bleed :) (I've in the past worked with some devices which didn't update the device-trees when kernel was updated...) Do you think you could live with using this existing convention? :) Yours, -- Matti