From: <Arun.Ramadoss@microchip.com>
To: <dev@pschenker.ch>, <netdev@vger.kernel.org>
Cc: <andrew@lunn.ch>, <olteanv@gmail.com>,
<krzysztof.kozlowski+dt@linaro.org>, <Woojung.Huh@microchip.com>,
<davem@davemloft.net>, <philippe.schenker@impulsing.ch>,
<linux-kernel@vger.kernel.org>, <edumazet@google.com>,
<conor+dt@kernel.org>, <marex@denx.de>,
<devicetree@vger.kernel.org>, <UNGLinuxDriver@microchip.com>,
<stefan.portmann@impulsing.ch>, <kuba@kernel.org>,
<robh+dt@kernel.org>, <pabeni@redhat.com>, <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next v2 2/2] net: dsa: Add KSZ8567 switch support
Date: Tue, 30 Jan 2024 04:03:32 +0000 [thread overview]
Message-ID: <8b6575afdba8c3207752ebfa1cddc490f7bee5a4.camel@microchip.com> (raw)
In-Reply-To: <20240125080504.62061-2-dev@pschenker.ch>
Hi Philippe,
On Thu, 2024-01-25 at 09:05 +0100, Philippe Schenker wrote:
>
> diff --git a/include/linux/platform_data/microchip-ksz.h
> b/include/linux/platform_data/microchip-ksz.h
> index f177416635a2..c4466e56d9d7 100644
> --- a/include/linux/platform_data/microchip-ksz.h
> +++ b/include/linux/platform_data/microchip-ksz.h
> @@ -24,6 +24,7 @@
>
> enum ksz_chip_id {
> KSZ8563_CHIP_ID = 0x8563,
> + KSZ8567_CHIP_ID = 0x00856700,
> KSZ8795_CHIP_ID = 0x8795,
> KSZ8794_CHIP_ID = 0x8794,
> KSZ8765_CHIP_ID = 0x8765,
nitpick: can you move KSZ8567 adjacent to KSZ9567. Since first KSZ8x
chips have chipid of 16 bits length. Others have 32 bits length.
otherwise it looks good to me.
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
> --
> 2.34.1
>
prev parent reply other threads:[~2024-01-30 4:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 8:05 [PATCH net-next v2 1/2] dt-bindings: net: dsa: Add KSZ8567 switch support Philippe Schenker
2024-01-25 8:05 ` [PATCH net-next v2 2/2] " Philippe Schenker
2024-01-30 4:03 ` Arun.Ramadoss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b6575afdba8c3207752ebfa1cddc490f7bee5a4.camel@microchip.com \
--to=arun.ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=dev@pschenker.ch \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=philippe.schenker@impulsing.ch \
--cc=robh+dt@kernel.org \
--cc=stefan.portmann@impulsing.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).