From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jonas Gorski <jonas.gorski@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: spi: convert spi-brcm63xx.txt to YAML
Date: Mon, 17 Jul 2023 09:32:15 +0200 [thread overview]
Message-ID: <8b70a042-bd9e-6c4d-dc71-07d807a1f960@linaro.org> (raw)
In-Reply-To: <20230715100211.14726-1-jonas.gorski@gmail.com>
On 15/07/2023 12:02, Jonas Gorski wrote:
> Changes done during conversion:
>
> * added a description, lifting and adapting the limitation sentence from
> brcm,bcm63xx-hsspi.yml
> * added appropriate compatibles for
...
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - brcm,bcm6368-spi
> + - brcm,bcm6362-spi
> + - brcm,bcm63268-spi
> + - const: brcm,bcm6358-spi
> + - const: brcm,bcm6348-spi
> + - const: brcm,bcm6358-spi
These two are just enum. It's preferred syntax.
> +
> + reg:
> + items:
> + - description: main registers
Instead shorter:
maxItems: 1
With above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-17 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 10:02 [PATCH] dt-bindings: spi: convert spi-brcm63xx.txt to YAML Jonas Gorski
2023-07-17 7:32 ` Krzysztof Kozlowski [this message]
2023-07-27 7:09 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b70a042-bd9e-6c4d-dc71-07d807a1f960@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).