From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc8280xp-crd: Fix naming of regulators
Date: Tue, 20 Jun 2023 22:42:12 +0200 [thread overview]
Message-ID: <8b8c35ba-e495-6363-e8fd-65e60bc6e879@linaro.org> (raw)
In-Reply-To: <20230620203915.141337-2-quic_bjorande@quicinc.com>
On 20.06.2023 22:39, Bjorn Andersson wrote:
> The external regulators in the CRD seems to have inherited their names
> from the X13s DeviceTree, correct them.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
Please also update the node names to match.
Konrad
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> index b21b41a066b6..678cdf253f2e 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> @@ -133,7 +133,7 @@ vreg_edp_3p3: regulator-edp-3p3 {
> vreg_edp_bl: regulator-edp-bl {
> compatible = "regulator-fixed";
>
> - regulator-name = "VBL9";
> + regulator-name = "VREG_EDP_BL";
> regulator-min-microvolt = <3600000>;
> regulator-max-microvolt = <3600000>;
>
> @@ -149,7 +149,7 @@ vreg_edp_bl: regulator-edp-bl {
> vreg_nvme: regulator-nvme {
> compatible = "regulator-fixed";
>
> - regulator-name = "VCC3_SSD";
> + regulator-name = "VREG_NVME_3P3";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
>
> @@ -163,7 +163,7 @@ vreg_nvme: regulator-nvme {
> vreg_misc_3p3: regulator-misc-3p3 {
> compatible = "regulator-fixed";
>
> - regulator-name = "VCC3B";
> + regulator-name = "VREG_MISC_3P3";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
>
> @@ -180,7 +180,7 @@ vreg_misc_3p3: regulator-misc-3p3 {
> vreg_wlan: regulator-wlan {
> compatible = "regulator-fixed";
>
> - regulator-name = "VCC_WLAN_3R9";
> + regulator-name = "VPH_PWR_WLAN";
> regulator-min-microvolt = <3900000>;
> regulator-max-microvolt = <3900000>;
>
> @@ -196,7 +196,7 @@ vreg_wlan: regulator-wlan {
> vreg_wwan: regulator-wwan {
> compatible = "regulator-fixed";
>
> - regulator-name = "VCC3B_WAN";
> + regulator-name = "SDX_VPH_PWR";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
>
next prev parent reply other threads:[~2023-06-20 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 20:39 [PATCH 1/2] arm64: dts: qcom: sc8280xp-crd: Correct vreg_misc_3p3 GPIO Bjorn Andersson
2023-06-20 20:39 ` [PATCH 2/2] arm64: dts: qcom: sc8280xp-crd: Fix naming of regulators Bjorn Andersson
2023-06-20 20:42 ` Konrad Dybcio [this message]
2023-06-21 6:52 ` Johan Hovold
2023-06-21 7:07 ` Johan Hovold
2023-06-20 20:41 ` [PATCH 1/2] arm64: dts: qcom: sc8280xp-crd: Correct vreg_misc_3p3 GPIO Konrad Dybcio
2023-06-21 7:04 ` Johan Hovold
2023-07-10 5:07 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b8c35ba-e495-6363-e8fd-65e60bc6e879@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox