From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F86C433F5 for ; Tue, 19 Apr 2022 19:40:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345657AbiDSTnU (ORCPT ); Tue, 19 Apr 2022 15:43:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233847AbiDSTnL (ORCPT ); Tue, 19 Apr 2022 15:43:11 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B761F40A3A for ; Tue, 19 Apr 2022 12:40:27 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id l7so35068128ejn.2 for ; Tue, 19 Apr 2022 12:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=QPOqgsEid6Wqxx1M40rGK1q2D5Xysrda2vwxz+DKUPc=; b=Ov/14cWHpDKy5PQzUQZKB6HCjf/IXjwsbqJGUZ5ZgQSB0Nvi5HVGxGRPW0J73z29L7 cQAMtVhwFPyV4fsWvz9sin/nxOJ5nX76c3cwKLa7RU/Af+R+NwozF+GGqqmzhV/z7r+z B6/hzWzcQzCs+P6k40mSURlW7eG0E9z/ZXS/qG2MiiseRag8zVEOM3tRGquuk+C7BC6T SfQLe+ElfqVxf04HDySjhuEZdLIaexqei9P73XfigZ3VCeWoEJHdCl6rz0RNdxv/j9fR JA1Log/TBQ8umsABpgUIR5JFXjU9Jmt98jqQmeZgCSnZDELufrTubTIFo1U7gBgDcoF0 LzoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=QPOqgsEid6Wqxx1M40rGK1q2D5Xysrda2vwxz+DKUPc=; b=KVpUtPMCyG3zFDVogMEXGvENaUIzDXT8mp6YeKaN6xCt+SkCVqR3I9fpDaVcMn+OXP kGnhkQyz9ywrJ14bqZgstKytA0Dk/32XIHC78ao1hez2NChsdlayfl3Nl197hmtdW91G +fn5/5bNOFxrIiGguAW5u4Rs5cxqd6HCc0ZubIxw62mSrqOzZsoMTIkxLec9S2kO3j3S FrxmfC/jEMiV8IvCakGnnC9ePC3aZg8uQDpSJNIz+ytYKikjdKhgFuRH+o/mkr+ktxBW NncJusdyDzr3QMqThqj275J6tbgXCuyLuslOqMd+Tm9fR2sDLU1FCyCxR574xoCl6QgP 0+1Q== X-Gm-Message-State: AOAM530kSCvnCpBgzNwLUrC7KnYnH2g9eHgE54JaGInO5n88GeEpz4V/ Hvi5KFiuCHWVDxsiWxHDsQfKzw== X-Google-Smtp-Source: ABdhPJx6DouuY7dAxuX1ycupL8N+u0hCgEeKCHYUoIMUdZg7qUxXIXsBqnuYBYopZ2gDNL26oum7Kg== X-Received: by 2002:a17:907:6e92:b0:6e4:de0d:464 with SMTP id sh18-20020a1709076e9200b006e4de0d0464mr14986441ejc.348.1650397226276; Tue, 19 Apr 2022 12:40:26 -0700 (PDT) Received: from [192.168.0.221] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id u6-20020a17090626c600b006e74ef7f092sm6012164ejc.176.2022.04.19.12.40.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 12:40:25 -0700 (PDT) Message-ID: <8b9ad0a6-acc0-aad9-c49d-e4a4b38374bb@linaro.org> Date: Tue, 19 Apr 2022 21:40:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: Aw: Re: [RFC/RFT 2/6] dt-bindings: soc: grf: add pcie30-{phy,pipe}-grf Content-Language: en-US To: Frank Wunderlich Cc: Frank Wunderlich , linux-rockchip@lists.infradead.org, Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , Philipp Zabel , Johan Jonker , Peter Geis , Michael Riesch , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20220416135458.104048-1-linux@fw-web.de> <20220416135458.104048-3-linux@fw-web.de> <02b3fe1c-12f9-8f96-a9b5-df44ca001825@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/04/2022 19:29, Frank Wunderlich wrote: >> Gesendet: Montag, 18. April 2022 um 17:54 Uhr >> Von: "Krzysztof Kozlowski" > >>> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml >>> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml >>> @@ -14,6 +14,8 @@ properties: >>> oneOf: >>> - items: >>> - enum: >>> + - rockchip,pcie30-phy-grf >>> + - rockchip,pcie30-pipe-grf >> >> These are without SoC parts. Are these PCIe v3 General Register Files >> part of some PCIe spec? > > imho they are shared across SoCs rk3568 and rk3588, but have only seen rk3568 implementation yet. > PCIe driver currently supports these 2 Soc (different offsets in the Phy-GRF), but can only test rk3568. > > pipe-grf seems only be used for rk35688 (offset used in probe is defined for this SoC), which i cannot test. > > so i have left them SoC independed. Compatibles should be SoC dependent, with some exceptions. Lack of documentation or lack of possibility of testing is actually argument against any exception, so they should be SoC specific/dependent. Best regards, Krzysztof