From: Matthias Brugger <matthias.bgg@gmail.com>
To: Pin-yen Lin <treapking@chromium.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Evan Benn <evanbenn@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Eizan Miyamoto <eizan@chromium.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5] arm64: dts: mt8173-elm: Switch to SMC watchdog
Date: Wed, 1 Feb 2023 14:17:41 +0100 [thread overview]
Message-ID: <8b9e509c-2ff8-7948-17a8-54c2d98713cb@gmail.com> (raw)
In-Reply-To: <20220729053254.220585-1-treapking@chromium.org>
On 29/07/2022 07:32, Pin-yen Lin wrote:
> Switch to SMC watchdog because we need direct control of HW watchdog
> registers from kernel. The corresponding firmware was uploaded in
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
Applied, sorry for the delay!
Matthias
> ---
>
> Changes in v5:
> - Remove redundant new line.
>
> Changes in v4:
> - Rename the watchdog node (smc_watchdog -> watchdog)
> - Correct the patch summary (mt8173-oak -> mt8173-elm)
>
> Changes in v3:
> - Remove /delete-node/ and create a new node for SMC watchdog.
>
> Changes in v2:
> - Move the modifications to mt8173-elm.dtsi and add some comments.
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index e21feb85d822..abe3140cfcc6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -161,6 +161,18 @@ hdmi_connector_in: endpoint {
> };
> };
> };
> +
> + watchdog {
> + compatible = "arm,smc-wdt";
> + };
> +};
> +
> +/*
> + * Disable the original MMIO watch dog and switch to the SMC watchdog, which
> + * operates on the same MMIO.
> + */
> +&watchdog {
> + status = "disabled";
> };
>
> &mfg_async {
prev parent reply other threads:[~2023-02-01 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 5:32 [PATCH v5] arm64: dts: mt8173-elm: Switch to SMC watchdog Pin-yen Lin
2022-07-29 8:36 ` AngeloGioacchino Del Regno
2022-10-13 3:37 ` Pin-yen Lin
2023-02-01 13:17 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b9e509c-2ff8-7948-17a8-54c2d98713cb@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=eizan@chromium.org \
--cc=evanbenn@chromium.org \
--cc=hsinyi@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=treapking@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).