From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alex Elder <elder@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Alex Elder <elder@riscstar.com>
Subject: Re: [PATCH net-next v2 2/3] dt-bindings: net: qcom,ipa: Add sram property for describing IMEM slice
Date: Tue, 27 May 2025 13:35:29 +0200 [thread overview]
Message-ID: <8baba1b0-6f47-4c19-a853-f48d036b5c10@kernel.org> (raw)
In-Reply-To: <20250527-topic-ipa_imem-v2-2-6d1aad91b841@oss.qualcomm.com>
On 27/05/2025 13:26, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> The IPA driver currently grabs a slice of IMEM through hardcoded
> addresses. Not only is that ugly and against the principles of DT,
> but it also creates a situation where two distinct platforms
> implementing the same version of IPA would need to be hardcoded
> together and matched at runtime.
>
> Instead, do the sane thing and accept a handle to said region directly.
>
> Don't make it required on purpose, as a) it's not there on ancient
> implementations (currently unsupported) and we're not yet done with
> filling the data across al DTs.
>
> Reviewed-by: Alex Elder <elder@riscstar.com>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-27 11:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 11:26 [net-next PATCH v2 0/3] Grab IPA IMEM slice through DT Konrad Dybcio
2025-05-27 11:26 ` [PATCH net-next v2 1/3] dt-bindings: sram: qcom,imem: Allow modem-tables Konrad Dybcio
2025-05-27 11:35 ` Krzysztof Kozlowski
2025-05-27 11:36 ` Konrad Dybcio
2025-05-27 11:42 ` Krzysztof Kozlowski
2025-07-14 17:53 ` Konrad Dybcio
2025-07-15 6:37 ` Krzysztof Kozlowski
2025-07-30 12:07 ` Konrad Dybcio
2025-07-30 13:14 ` Krzysztof Kozlowski
2025-07-31 9:47 ` Konrad Dybcio
2025-08-03 9:20 ` Krzysztof Kozlowski
2025-05-27 11:26 ` [PATCH net-next v2 2/3] dt-bindings: net: qcom,ipa: Add sram property for describing IMEM slice Konrad Dybcio
2025-05-27 11:35 ` Krzysztof Kozlowski [this message]
2025-05-27 11:26 ` [PATCH net-next v2 3/3] net: ipa: Grab IMEM slice base/size from DTS Konrad Dybcio
2025-05-28 15:08 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8baba1b0-6f47-4c19-a853-f48d036b5c10@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=elder@riscstar.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).