From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Martyn Welch <martyn.welch@collabora.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Cc: kernel@collabora.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: sm2s-imx8mp: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board
Date: Wed, 20 Jul 2022 19:11:29 +0200 [thread overview]
Message-ID: <8bc1d085-eb81-c50c-ec66-3f0a621a9a9c@linaro.org> (raw)
In-Reply-To: <20220720150007.2168051-3-martyn.welch@collabora.com>
On 20/07/2022 17:00, Martyn Welch wrote:
> Add device trees for one of a number of MSCs variants of the SM2S-IMX8PLUS
> system on module along with the compatible SM2S-SK-AL-EP1 carrier board.
> As the name suggests, this family of SoMs use the NXP i.MX8MP SoC and
> provide the SMARC module interface.
>
> Signed-off-by: Martyn Welch <martyn.welch@collabora.com>> ---
>
> Changes in v2
> - Added compatibles
> - Removed underscores from node names
> - Make node names more generic
> - Reorder properties
> - Fix issues found by dtbs_check in these files
>
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++
> .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 52 ++
Subject prefix is somehow reversed. sm2s is not a SoC.
arm64: dts: imx8mp-msc-sm2s:
Rest looks ok, except the discussion about actual company prefix.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-20 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 15:00 [PATCH v2 1/3] dt-bindings: vendor-prefixes: add MSC Technologies Martyn Welch
2022-07-20 15:00 ` [PATCH v2 2/3] dt-bindings: arm: fsl: Add MSC SM2S-IMX8PLUS SoM and SM2-MB-EP1 Carrier Martyn Welch
2022-07-20 20:32 ` Rob Herring
2022-07-20 15:00 ` [PATCH v2 3/3] arm64: dts: sm2s-imx8mp: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board Martyn Welch
2022-07-20 17:11 ` Krzysztof Kozlowski [this message]
2022-07-20 17:07 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: add MSC Technologies Krzysztof Kozlowski
2022-07-21 8:03 ` Martyn Welch
2022-07-21 8:46 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bc1d085-eb81-c50c-ec66-3f0a621a9a9c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@collabora.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).