From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Gautam Subject: Re: [PATCH v11 0/4] iommu/arm-smmu: Add runtime pm/sleep support Date: Fri, 18 May 2018 15:44:01 +0530 Message-ID: <8bda01d5-61aa-d163-3b25-e8b055d54644@codeaurora.org> References: <20180322102204.14760-1-vivek.gautam@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Robin Murphy , Will Deacon Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lukas Wunner , Stephen Boyd , "Rafael J. Wysocki" , Linux Kernel Mailing List , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Rob Herring , linux-arm-msm List-Id: devicetree@vger.kernel.org Hi Robin, On 4/9/2018 9:52 AM, Tomasz Figa wrote: > Hi Will, Robin, > > On Thu, Mar 22, 2018 at 7:22 PM Vivek Gautam > wrote: > >> This series provides the support for turning on the arm-smmu's >> clocks/power domains using runtime pm. This is done using the >> recently introduced device links patches, which lets the smmu's >> runtime to follow the master's runtime pm, so the smmu remains >> powered only when the masters use it. >> As not all implementations support clock/power gating, we are checking >> for a valid 'smmu->dev's pm_domain' to conditionally enable the runtime >> power management for such smmu implementations that can support it. >> This series also adds support for Qcom's arm-smmu-v2 variant that >> has different clocks and power requirements. >> Took some reference from the exynos runtime patches [1]. >> With conditional runtime pm now, we avoid touching dev->power.lock >> in fastpaths for smmu implementations that don't need to do anything >> useful with pm_runtime. >> This lets us to use the much-argued pm_runtime_get_sync/put_sync() >> calls in map/unmap callbacks so that the clients do not have to >> worry about handling any of the arm-smmu's power. >> Previous version of this patch series is @ [5]. >> [v11] >> * Some more cleanups for device link. We don't need an explicit >> delete for device link from the driver, but just set the flag >> DL_FLAG_AUTOREMOVE. >> device_link_add() API description says - >> "If the DL_FLAG_AUTOREMOVE is set, the link will be removed >> automatically when the consumer device driver unbinds." >> * Addressed the comments for 'smmu' in arm_smmu_map/unmap(). >> * Dropped the patch [10] that introduced device_link_del_dev() API. > As far as I can see, this version addresses all the earlier comments. Do > you think this is something that you could apply? > > Best regards, > Tomasz Gentle ping. Are we picking this series for 4.18? Regards Vivek