From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed2-f12.google.com (mail-ed2-f12.google.com [74.125.228.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1EF94BF95E for ; Thu, 17 Sep 2026 12:32:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789648331; cv=none; b=fHkmScSU83pkK46tJKmfJoC63JSCsTaFuzJCdtKMo2a2EeBhUP1RuZf9scBEhRnkXouF1WzOjU0kpps/8DSidtyafCx+yFXo4zJlWkduIg3ng4QYdBzaWaZBMlbKxcevY/SQERjHGexgeJZRbtVuz3vcIu0XNTcSt/lHTlKlm3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789648331; c=relaxed/simple; bh=3w1QO9RRjV2P//77/vuGY3t+8liMQZidimN+GXQ/Shw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MtK2t52ShrWyr7NWL1imrpiBvhR5b+SMjZZFLlWJ+0qbzL32EcDPcAoscaK1OHi9G59/+VGAez2fM99mlB8yql+xZgU6VZTr+7IBcKr7cYeF7wffOOKYhyi363o9nwYKRRH4byc2VJ35VzaXV+y+SPgpr+nH7aSKRVAXaqsNUtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=e/fiuBNL; arc=none smtp.client-ip=74.125.228.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e/fiuBNL" Received: by mail-ed2-f12.google.com with SMTP id 4fb4d7f45d1cf-6a64c7cdb46so1326096a12.3 for ; Thu, 17 Sep 2026 05:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1789648323; x=1790253123; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ls/PIdXgwRaJNqkytOniziANCA/o27n7uKp1MTR7az8=; b=e/fiuBNLG4E9oZeVsqDRZUNO6JWwxgCRIyimmkUghYQJnr2LhxsdxwaEvvpCdtStT9 u0Cz2Xeowdpk7x0SKOZbSgxmJN46MGJE+ZFeQA4S0wBM2uZZOay4bh6EJXPcol3DYd18 3R5++iHttO7Zp/N0uoYJpa1OgoCbiUlY910aXYyOd9O+/k2FigozCEmn99+I4rxW16Pm 5jJb2ROGGdfsyeOU0SbAxG1m5vwxLm5/2LltsV+9RpfJ0C0ZHu8hdflC1XRtfZsm4NDl FSGDOB+UXLIQ9DORzJDy5aF0EkLB7fkm27qqdP9LAku2yBqxmD0HhyPYTiLjfpMu831F vkxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789648323; x=1790253123; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ls/PIdXgwRaJNqkytOniziANCA/o27n7uKp1MTR7az8=; b=Xe2aOutiCT1AYgK0kspdhRgsKv9oGhxs3edyXm75BPCpV3sHb7Etne93U+Rp7pF17B knIV43PJjU4Jp5WRtdcEWlR5Ub7G0WRmHJKgm2DBOiabc1ZToYwRQV2pVobXDfb5GZcQ ihHMpZHwfDzOmwlxnWQM5qkK6m7rRxN+blWg7SytQjnJ7qqIBGY1SYE2vshng4/0FRXo KE9PTl7ng9jnavtmw2IpEP9vn3crOUApplwR0Kl5UP3n0JHheDc5xKMyC19tbZDZ3Za5 yWE4sHDCLcVnyMaAXUCsacAJKJ5rZY6kGUeQUSBDXs2SlekJ181/wrkoPUWYyAsOMe5c iMTQ== X-Forwarded-Encrypted: i=1; AKwUvBz7tATHxRBSbhg+eobPVLM04PkAouPae6ZPrEVuRTfSttDSbQU8oNw+IP/OegbTacUv9V+u2vUQSOjO@vger.kernel.org X-Gm-Message-State: AFuF++mSdr3HLwEt65SM/ZCgABQCzIzOsqYAqR+2i2yFmzDiSAeOB1gT U7uiscEkdw7hdbqEPPvkI9t6gUpdf+e0i2w1kAC/x63255MZiPPXS03sSpzT683qh4EOO8DfaQH jb9FSaes= X-Gm-Gg: AYBFou1fe1Tqd3aTDvBjtgzIQQf2XqciK7RJGGYClJAJ4OBcdqApc/lpwYRvt38mOug chnQjEMnaiNSjD13mFGLALBCMQ2Ywd1P9eQzuwwjd8JfC9IXqp0UPCI5vYZCiHtb4+ClNcNl/P5 qOecZ3JvCQMjAmAXo9NvH1zLe2hyhTdmLXG45u4kYWi4wDNy6JBEhvEf/fKNJcKvDD3FN9Betye Y7l83kvHMxZXaSbVJdCvIGyEXr8oSkRBpu+96Ch0NMFH3ahI8w2q4ROG6wFep1lOp5kFY9mCaYR qGbObZPSOmHf+S1zFSJGGXnZYLlWYiZMxQoTwjCI0UQnxdpktluqHvhGA6LncWVRecqXmsY4WX3 KRZbpB5lv9dILzmB07KIi4AgiqU/pfRZdmNS/IhEjoAXz6mPlWKGqwytgZLv0AIHmVkQQnuYvwe 01WB/o1KyQA/lzF2Ed1BNQKsnqIByHn4elCQp3AydNvIh4vOCHgUWQXS5iGSDH0BsyFiHDOZ5Hz yhUKf+OYIw= X-Received: by 2002:a05:6402:3242:b0:6a7:f25b:d281 with SMTP id 4fb4d7f45d1cf-6aa22383344mr3922846a12.13.1789648323558; Thu, 17 Sep 2026 05:32:03 -0700 (PDT) Received: from [192.168.0.167] ([109.76.29.130]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6aa1d2ab4ebsm3576964a12.30.2026.09.17.05.32.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2026 05:32:03 -0700 (PDT) Message-ID: <8bed3f8f-52dd-4ab7-9ce2-cc756724893d@linaro.org> Date: Thu, 17 Sep 2026 13:32:01 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v18 2/5] phy: core: Add phy_get_by_of_node() To: Neil Armstrong , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy , Bryan O'Donoghue , Loic Poulain , Vinod Koul , Greg Kroah-Hartman , Kishon Vijay Abraham I , Felipe Balbi , Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-phy@lists.infradead.org, Krzysztof Kozlowski References: <20260917-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v18-0-f85c9103177e@linaro.org> <20260917-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v18-2-f85c9103177e@linaro.org> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17/09/2026 13:29, Neil Armstrong wrote: >>   /** >>    * _of_phy_get() - lookup and obtain a reference to a phy by phandle >>    * @np: device_node for which to get the phy >>    * @index: the index of the phy >>    * >> - * Returns the phy associated with the given phandle value, >> - * after getting a refcount to it or -ENODEV if there is no such phy or >> - * -EPROBE_DEFER if there is a phandle to the phy, but the device is >> - * not yet loaded. This function uses of_xlate call back function >> provided >> - * while registering the phy_provider to find the phy instance. >> + * Returns the phy associated with the given phandle value after getting >> + * a refcount to it; -ENODEV if there is no such phy or the phy is >> + * disabled; -EPROBE_DEFER if the phy provider is not yet available. >>    */ > > Why changing the comment here ? You're not supposed to changes the > _of_phy_get() behaviour. I have no real memory of that change probably seemd like a good idea at the time. Will drop --- bod