devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Matthew Gerlach <matthew.gerlach@linux.intel.com>,
	lpieralisi@kernel.org, kw@linux.com,
	manivannan.sadhasivam@linaro.org, robh@kernel.org,
	bhelgaas@google.com, krzk+dt@kernel.org, conor+dt@kernel.org,
	dinguyen@kernel.org, joyce.ooi@intel.com,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: matthew.gerlach@altera.com, peter.colberg@altera.com
Subject: Re: [PATCH v6 2/7] arm64: dts: agilex: Fix fixed-clock schema warnings
Date: Wed, 12 Feb 2025 06:56:09 +0100	[thread overview]
Message-ID: <8bf87b59-fe80-4bb5-a558-bff35d876e67@kernel.org> (raw)
In-Reply-To: <20250211151725.4133582-3-matthew.gerlach@linux.intel.com>

On 11/02/2025 16:17, Matthew Gerlach wrote:
> Add required clock-frequency property to fixed-clock nodes
> to fix schema check warnings.
> 
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> ---
> v6:
>  - New patch to series.
> ---
>  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> index 1235ba5a9865..42cb24cfa6da 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> @@ -114,21 +114,25 @@ clocks {
>  		cb_intosc_hs_div2_clk: cb-intosc-hs-div2-clk {
>  			#clock-cells = <0>;
>  			compatible = "fixed-clock";
> +			clock-frequency = <0>;

That's not a correct frequency. You silence some error by introducing
incorrect properties. That's wrong.

Don't fix the warnings just to silence them, while keeping actual errors
still in the code.

Best regards,
Krzysztof

  reply	other threads:[~2025-02-12  5:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 15:17 [PATCH v6 0/7] Add PCIe Root Port support for Agilex family of chips Matthew Gerlach
2025-02-11 15:17 ` [PATCH v6 1/7] dt-bindings: PCI: altera: Add binding for Agilex Matthew Gerlach
2025-02-11 15:17 ` [PATCH v6 2/7] arm64: dts: agilex: Fix fixed-clock schema warnings Matthew Gerlach
2025-02-12  5:56   ` Krzysztof Kozlowski [this message]
2025-02-13 17:37     ` matthew.gerlach
2025-02-13 18:03       ` Krzysztof Kozlowski
2025-02-11 15:17 ` [PATCH v6 3/7] arm64: dts: agilex: move bus@80000000 to socfpga_agilex.dtsi Matthew Gerlach
2025-02-12  5:57   ` Krzysztof Kozlowski
2025-02-11 15:17 ` [PATCH v6 4/7] arm64: dts: agilex: refactor shared dts into dtsi Matthew Gerlach
2025-02-12  5:59   ` Krzysztof Kozlowski
2025-02-11 15:17 ` [PATCH v6 5/7] arm64: dts: agilex: add dtsi for PCIe Root Port Matthew Gerlach
2025-02-11 15:17 ` [PATCH v6 6/7] arm64: dts: agilex: add dts enabling " Matthew Gerlach
2025-02-12  6:00   ` Krzysztof Kozlowski
2025-02-11 15:17 ` [PATCH v6 7/7] PCI: altera: Add Agilex support Matthew Gerlach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bf87b59-fe80-4bb5-a558-bff35d876e67@kernel.org \
    --to=krzk@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=joyce.ooi@intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=matthew.gerlach@altera.com \
    --cc=matthew.gerlach@linux.intel.com \
    --cc=peter.colberg@altera.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).