devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ying Liu <gnuiyl@gmail.com>
Cc: Liu Ying <victor.liu@nxp.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, neil.armstrong@linaro.org,
	conor+dt@kernel.org, rfoss@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, jonas@kwiboo.se,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	jernej.skrabec@gmail.com, robh+dt@kernel.org,
	Laurent.pinchart@ideasonboard.com, andrzej.hajda@intel.com,
	kernel@pengutronix.de, linux-imx@nxp.com
Subject: Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add NXP i.MX93 parallel display format configuration
Date: Sun, 4 Jun 2023 12:16:31 +0200	[thread overview]
Message-ID: <8c0b1e70-382d-669c-c0ee-438fada6e78a@linaro.org> (raw)
In-Reply-To: <CAOcKUNWkubMK1MJS73tpbm4bafQv2GAMuq_JOTFbvB9EVDRvxg@mail.gmail.com>

On 02/06/2023 05:54, Ying Liu wrote:
> On Fri, Jun 2, 2023 at 1:45 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 31/05/2023 11:32, Liu Ying wrote:
>>> NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
>>> configures parallel display format by using the "PARALLEL_DISP_FORMAT"
>>> field. Add device tree bindings for the display format configuration.
>>>
>>> Signed-off-by: Liu Ying <victor.liu@nxp.com>
>>> ---
>>> v1->v2:
>>> * No change.
>>
>> How did you implement Rob's comment?
> 
> Should have discussed more in v1 about Rob's comment, but
> let me explain why this dt-binding makes sense here:

"It needs to be defined as part of the mediamix blkctrl
schema though."

Where is it defined in mediamix blkctrl?



Best regards,
Krzysztof


  reply	other threads:[~2023-06-04 10:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31  9:32 [PATCH v2 0/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support Liu Ying
2023-05-31  9:32 ` [PATCH v2 1/2] dt-bindings: display: bridge: Add NXP i.MX93 parallel display format configuration Liu Ying
2023-06-01 17:45   ` Krzysztof Kozlowski
2023-06-02  3:54     ` Ying Liu
2023-06-04 10:16       ` Krzysztof Kozlowski [this message]
2023-06-05  6:20         ` Ying Liu
2023-05-31  9:32 ` [PATCH v2 2/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support Liu Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c0b1e70-382d-669c-c0ee-438fada6e78a@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=andrzej.hajda@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gnuiyl@gmail.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).