From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Garmin.Chang" <Garmin.Chang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Richard Cochran <richardcochran@gmail.com>
Cc: Project_Global_Chrome_Upstream_Group@mediatek.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 04/19] clk: mediatek: Add MT8188 peripheral clock support
Date: Thu, 27 Oct 2022 10:22:23 +0200 [thread overview]
Message-ID: <8c0da3f2-0e77-e960-dab4-0a1d02e0d21e@collabora.com> (raw)
In-Reply-To: <20221024094254.29218-5-Garmin.Chang@mediatek.com>
Il 24/10/22 11:42, Garmin.Chang ha scritto:
> Add MT8188 peripheral clock controller which provides clock
> gate control for ethernet/flashif/pcie/ssusb.
>
> Signed-off-by: Garmin.Chang <Garmin.Chang@mediatek.com>
..snip..
> +
> +static const struct of_device_id of_match_clk_mt8188_peri_ao[] = {
> + {
> + .compatible = "mediatek,mt8188-pericfg_ao",
> + .data = &peri_ao_desc,
> + }, {
> + /* sentinel */
> + }
> +};
> +
Here and for all of the other drivers that you're introducing with this series...
please compress this array to one line per entry, like so:
static const struct of_device_id of_match_clk_mt8188_peri_ao[] = {
{ .compatible = "mediatek,mt8188-pericfg_ao", .data = &peri_ao_desc },
{ /* sentinel */ }
};
Regards,
Angelo
next prev parent reply other threads:[~2022-10-27 8:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221024094254.29218-1-Garmin.Chang@mediatek.com>
[not found] ` <20221024094254.29218-4-Garmin.Chang@mediatek.com>
2022-10-27 8:21 ` [PATCH v2 03/19] clk: mediatek: Add MT8188 topckgen clock support AngeloGioacchino Del Regno
2022-12-23 7:36 ` Garmin Chang (張家銘)
[not found] ` <20221024094254.29218-3-Garmin.Chang@mediatek.com>
2022-10-27 8:21 ` [PATCH v2 02/19] clk: mediatek: Add MT8188 apmixedsys " AngeloGioacchino Del Regno
2022-12-23 7:35 ` Garmin Chang (張家銘)
[not found] ` <20221024094254.29218-5-Garmin.Chang@mediatek.com>
2022-10-27 8:22 ` AngeloGioacchino Del Regno [this message]
2022-12-23 7:33 ` [PATCH v2 04/19] clk: mediatek: Add MT8188 peripheral " Garmin Chang (張家銘)
[not found] ` <20221024094254.29218-11-Garmin.Chang@mediatek.com>
2022-10-27 8:23 ` [PATCH v2 10/19] clk: mediatek: Add MT8188 mfgcfg " AngeloGioacchino Del Regno
2022-12-23 1:36 ` Garmin Chang (張家銘)
[not found] ` <20221024094254.29218-9-Garmin.Chang@mediatek.com>
2022-10-27 8:25 ` [PATCH v2 08/19] clk: mediatek: Add MT8188 imgsys " AngeloGioacchino Del Regno
2022-12-12 7:53 ` Garmin Chang (張家銘)
[not found] ` <20221024094254.29218-2-Garmin.Chang@mediatek.com>
2022-10-27 13:42 ` [PATCH v2 01/19] dt-bindings: ARM: MediaTek: Add new document bindings of MT8188 clock Krzysztof Kozlowski
2022-12-23 8:20 ` Garmin Chang (張家銘)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c0da3f2-0e77-e960-dab4-0a1d02e0d21e@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Garmin.Chang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).