From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <robh+dt@kernel.org>,
<alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] ASoC: ti: Add custom machine driver for j721e EVM (CPB and IVI)
Date: Tue, 23 Jun 2020 12:28:57 +0300 [thread overview]
Message-ID: <8c255c3c-8c9c-9200-962f-69de9a1f861c@ti.com> (raw)
In-Reply-To: <20200612122757.GF5396@sirena.org.uk>
On 12/06/2020 15.27, Mark Brown wrote:
> On Fri, Jun 12, 2020 at 12:27:17PM +0300, Peter Ujfalusi wrote:
>
>>> + if (IS_ERR(clocks->target)) {
>>> + ret = PTR_ERR(clocks->target);
>>> + if (ret != -EPROBE_DEFER)
>>> + dev_err(dev, "failed to acquire %s': %d\n",
>
>> Looks like I have extra "'" in the prints...
>
> Apart from the issues you pointed out yourself this all looks reasonable
> to me.
Thanks Mark,
I'll wait for Rob on the binding doc side before I send the updated v4.
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
prev parent reply other threads:[~2020-06-23 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 8:59 [PATCH v3 0/3] ASoC: ti: Add support for audio on J721e EVM Peter Ujfalusi
2020-06-12 8:59 ` [PATCH v3 1/3] ASoC: ti: davinci-mcasp: Specify stream_name for playback/capture Peter Ujfalusi
2020-06-12 8:59 ` [PATCH v3 2/3] ASoC: dt-bindings: Add documentation for TI j721e EVM (CPB and IVI) Peter Ujfalusi
2020-06-12 8:59 ` [PATCH v3 3/3] ASoC: ti: Add custom machine driver for " Peter Ujfalusi
2020-06-12 9:27 ` Peter Ujfalusi
2020-06-12 12:27 ` Mark Brown
2020-06-23 9:28 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c255c3c-8c9c-9200-962f-69de9a1f861c@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox