From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Gerald Loacker <gerald.loacker@wolfvision.net>,
Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Jakob Hauser <jahau@rocketmail.com>,
Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [PATCH 1/2] dt-bindings: iio: magnetometer: add ti tmag5273 documentation file
Date: Thu, 17 Nov 2022 17:17:24 +0100 [thread overview]
Message-ID: <8c2da24c-ae10-40c9-bb3e-b300975a86d7@linaro.org> (raw)
In-Reply-To: <f52dcb6d-30ec-3d49-7e28-9761462d4799@wolfvision.net>
On 17/11/2022 17:12, Gerald Loacker wrote:
>>
>>> +
>>> + compatible:
>>> + const: ti,tmag5273
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + "#io-channel-cells":
>>> + const: 1
>>> +
>>> + ti,angle-enable:
>>> + description:
>>> + Enables angle measurement in the selected plane.
>>> + 0 = OFF
>>> + 1 = X-Y (default)
>>> + 2 = Y-Z
>>> + 3 = X-Z
>>
>> This feels like something we should be configuring at runtime rather that
>> DT, or is it driven by board design or similar?
>>
>
> We use this sensor for a zoom wheel application, there is an EVM from TI
> for this as well. So this is for setting the mounting position of the wheel.
That's ok, but does not explain why choice of angle measurement should
be a property of the hardware. I could imagine configuring device to
measure sometimes X-Y and sometimes X-Z, depending on the use case. Use
case can change runtime.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-17 16:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 7:37 [PATCH 0/2] add ti tmag5273 driver Gerald Loacker
2022-11-15 7:37 ` [PATCH 1/2] dt-bindings: iio: magnetometer: add ti tmag5273 documentation file Gerald Loacker
2022-11-15 8:21 ` Krzysztof Kozlowski
2022-11-15 17:43 ` Jonathan Cameron
2022-11-17 16:12 ` Gerald Loacker
2022-11-17 16:17 ` Krzysztof Kozlowski [this message]
2022-11-17 16:54 ` Jonathan Cameron
2022-11-17 17:01 ` Michael Riesch
2022-11-17 17:04 ` Krzysztof Kozlowski
2022-11-17 16:51 ` Jonathan Cameron
2022-11-15 7:37 ` [PATCH 2/2] iio: magnetometer: add ti tmag5273 driver Gerald Loacker
2022-11-15 13:32 ` Andy Shevchenko
2022-11-15 17:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c2da24c-ae10-40c9-bb3e-b300975a86d7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=jahau@rocketmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.riesch@wolfvision.net \
--cc=nikita.yoush@cogentembedded.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).