From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2C96C4332F for ; Tue, 22 Nov 2022 07:36:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232254AbiKVHg5 (ORCPT ); Tue, 22 Nov 2022 02:36:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbiKVHg4 (ORCPT ); Tue, 22 Nov 2022 02:36:56 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF795317C1 for ; Mon, 21 Nov 2022 23:36:54 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id bp15so22296724lfb.13 for ; Mon, 21 Nov 2022 23:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uq8x1FvZ2uEwbe4/V8DB199OoK2b/lP8Y41BLE+I0bE=; b=rWNPRBGm0URXEZopa+8WDX7Rzx3US+ec+m0iz0TUVLUMgGzIThatBejp6Of5HUXhzy hb/7UK7kXUWEF9EHhhdFi/2znLv9U+0cDDgAT08JYGMiTDJ8hmjqexIqp5mP4jud549L l/LaZPbh9qEj1govo14ortA/dskPiDBU18XEkqWzO7qh14JisJ1tNgrNaAXPxEL88Bot NW+JTASnFtumH4ysbb7YIHArDfbvkR10hyLmn2YWBeCQm6i5YLevAnLokL4Uv1jmhoHG gmkXgvoOYR/8EuCQgfromM/cmVsT7D3YIu0WFa8GHgpldxjh8MkdIUsIHeupDM1LkKl9 Br7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uq8x1FvZ2uEwbe4/V8DB199OoK2b/lP8Y41BLE+I0bE=; b=tPcznqGEYqkJxdflhHqkUe5z/qiW/t4r9rAjP3Z19zRAbzhxQ8PdneMbaHcneBWe6D wEPJiY6G3ZyJJcwvIXnlvM+JncVmLiIVnlCxGs76LO86FWbSThKnM+gvKWIEtdiS39BS k5yWivDMqqFxlPMpTDoFx/1MjZRPKnasWYUq7V4v9R4HcIMCYOwlC+nKOiVvEVE38Uvb 8rgHzYep0s1/yYd/uW5NdIlk+Yc+wvh0PA1/t91JpEtJq7cnGn+aEag+eJaUvxTrHf89 H2q0B3h8XRaUvedyI5PDwieJcqVWHKd67PPRQrtXO1TRmIpwQJx2HqC+wpjE8Impn2N8 exyA== X-Gm-Message-State: ANoB5pnlyh+uEV9h2tyDDmOCB0Q2PR7LZWG1ZJDYfXlNS6efLVDv03do hwPUBE7cPGNW00pUE6y/j/JayA== X-Google-Smtp-Source: AA0mqf6qifS0NcmndAPQz1+KIS+X+ObkeNCRNEe103YGGN3fVlWaUC/huvesOr+xfSGNOTYdcBDKhg== X-Received: by 2002:a19:f010:0:b0:4a2:2e81:9be5 with SMTP id p16-20020a19f010000000b004a22e819be5mr7786612lfc.486.1669102613104; Mon, 21 Nov 2022 23:36:53 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id f28-20020a05651c03dc00b0026fa9e19197sm1729259ljp.36.2022.11.21.23.36.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 23:36:52 -0800 (PST) Message-ID: <8c37d6a6-497c-f761-1e27-1ef5b3e64250@linaro.org> Date: Tue, 22 Nov 2022 08:36:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Content-Language: en-US To: Tony Lindgren Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Thierry Reding , Nishanth Menon , Vignesh Raghavendra References: <20221121115525.36362-1-tony@atomide.com> <20221121144000.7weeyfbbulltfxmd@pengutronix.de> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/11/2022 05:43, Tony Lindgren wrote: > * Krzysztof Kozlowski [221121 16:05]: >> On 21/11/2022 15:48, Tony Lindgren wrote: >>> * Uwe Kleine-König [221121 14:30]: >>>> On Mon, Nov 21, 2022 at 01:55:24PM +0200, Tony Lindgren wrote: >>>>> Let's allow node numbering in decimal format too. >>>>> >>>>> Simple human-readable increments/IDs are usually decimal, hex is only for >>>>> addresses as noted by Krzysztof Kozlowski . >>>>> >>>>> Cc: Thierry Reding >>>>> Cc: Uwe Kleine-König >>>>> Suggested-by: Krzysztof Kozlowski >>>>> Signed-off-by: Tony Lindgren >>>>> --- >>>>> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml >>>>> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml >>>>> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml >>>>> @@ -13,7 +13,7 @@ select: false >>>>> >>>>> properties: >>>>> $nodename: >>>>> - pattern: "^pwm(@.*|-[0-9a-f])*$" >>>>> + pattern: "^pwm(@.*|-([0-9a-f]|1[0-5]))*$" >>>> >>>> I wonder why you don't make this: >>>> >>>> + pattern: "^pwm(@.*|-[0-9a-f]*)$" >> >> Yes, the '*' should be within (). > > Sorry I guess I don't follow. So for what type of naming is the second '*' > actually needed here, or is it needed at all? > > We only want to match the following: > > pwm@1234 > > pwm-0 > ... > pwm-f > > And now also: > > pwm-0 > ... > pwm-15 > > Is there yet another format I'm missing? > >>> Hmm but I think this would also pass for node names like pwm-a-foo? >>> >> >> No, how? > > Because of the second extra '*' there :) It cannot multiple dashes... > > Regards, > > Tony Best regards, Krzysztof