From: Dmitry Osipenko <digetx@gmail.com>
To: Sameer Pujar <spujar@nvidia.com>,
perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org
Cc: broonie@kernel.org, lgirdwood@gmail.com,
thierry.reding@gmail.com, jonathanh@nvidia.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
sharadg@nvidia.com, mkumard@nvidia.com, viswanathl@nvidia.com,
rlokhande@nvidia.com, dramesh@nvidia.com, atalambedu@nvidia.com
Subject: Re: [PATCH v3 02/10] ASoC: tegra: add support for CIF programming
Date: Fri, 21 Feb 2020 08:27:55 +0300 [thread overview]
Message-ID: <8c39dbe9-a2b9-62e8-3a26-32cc747d0e60@gmail.com> (raw)
In-Reply-To: <1582180492-25297-3-git-send-email-spujar@nvidia.com>
20.02.2020 09:34, Sameer Pujar пишет:
> Audio Client Interface (CIF) is a proprietary interface employed to route
> audio samples through Audio Hub (AHUB) components by inter connecting the
> various modules.
>
> This patch exports an inline function tegra_set_cif() which can be used,
> for now, to program CIF on Tegra210 and later Tegra generations. Later it
> can be extended to include helpers for legacy chips as well.
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
> sound/soc/tegra/tegra_cif.h | 63 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 sound/soc/tegra/tegra_cif.h
>
> diff --git a/sound/soc/tegra/tegra_cif.h b/sound/soc/tegra/tegra_cif.h
> new file mode 100644
> index 0000000..ecc0850
> --- /dev/null
> +++ b/sound/soc/tegra/tegra_cif.h
> @@ -0,0 +1,63 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * tegra_cif.h - TEGRA Audio CIF Programming
> + *
> + * Copyright (c) 2020 NVIDIA CORPORATION. All rights reserved.
> + *
> + */
> +
> +#ifndef __TEGRA_CIF_H__
> +#define __TEGRA_CIF_H__
For completeness here should be:
#include <linux/regmap.h>
...
> +static inline void tegra_set_cif(struct regmap *regmap, unsigned int reg,
> + struct tegra_cif_conf *conf)
> +{
...
> + regmap_update_bits(regmap, reg, TEGRA_ACIF_UPDATE_MASK, value);
> +}
> +
> +#endif
>
Otherwise:
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
next prev parent reply other threads:[~2020-02-21 5:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 6:34 [PATCH v3 00/10] add ASoC components for AHUB Sameer Pujar
2020-02-20 6:34 ` [PATCH v3 01/10] dt-bindings: sound: tegra: add DT binding " Sameer Pujar
2020-02-21 12:39 ` Mark Brown
2020-02-26 16:02 ` Rob Herring
2020-02-20 6:34 ` [PATCH v3 02/10] ASoC: tegra: add support for CIF programming Sameer Pujar
2020-02-20 14:30 ` Jon Hunter
2020-02-21 5:27 ` Dmitry Osipenko [this message]
2020-02-20 6:34 ` [PATCH v3 03/10] ASoC: tegra: add Tegra210 based DMIC driver Sameer Pujar
2020-02-20 14:36 ` Jon Hunter
2020-02-21 5:53 ` Dmitry Osipenko
2020-02-21 13:00 ` Mark Brown
2020-02-21 14:31 ` Jon Hunter
2020-02-21 16:55 ` Mark Brown
2020-02-24 11:28 ` Jon Hunter
2020-02-24 11:44 ` Mark Brown
2020-02-24 12:29 ` Sameer Pujar
2020-02-24 13:18 ` Mark Brown
2020-02-28 7:30 ` Viswanath L
2020-02-20 6:34 ` [PATCH v3 04/10] ASoC: tegra: add Tegra210 based I2S driver Sameer Pujar
2020-02-20 14:45 ` Jon Hunter
2020-02-21 13:21 ` Mark Brown
2020-02-20 6:34 ` [PATCH v3 05/10] ASoC: tegra: add Tegra210 based AHUB driver Sameer Pujar
2020-02-20 6:51 ` Randy Dunlap
2020-02-20 15:08 ` Jon Hunter
2020-02-21 13:38 ` Mark Brown
2020-02-20 6:34 ` [PATCH v3 06/10] ASoC: tegra: add Tegra186 based DSPK driver Sameer Pujar
2020-02-20 6:53 ` Randy Dunlap
2020-02-20 15:10 ` Jon Hunter
2020-02-20 6:34 ` [PATCH v3 07/10] ASoC: tegra: add Tegra210 based ADMAIF driver Sameer Pujar
2020-02-20 6:55 ` Randy Dunlap
2020-02-20 15:16 ` Jon Hunter
2020-02-21 6:08 ` Dmitry Osipenko
2020-02-20 6:34 ` [PATCH v3 08/10] arm64: tegra: add AHUB components for few Tegra chips Sameer Pujar
2020-02-20 14:49 ` Jon Hunter
2020-02-20 6:34 ` [PATCH v3 09/10] arm64: tegra: enable AHUB modules " Sameer Pujar
2020-02-20 14:52 ` Jon Hunter
2020-02-20 6:34 ` [PATCH v3 10/10] arm64: defconfig: enable AHUB components for Tegra210 and later Sameer Pujar
2020-02-20 14:52 ` Jon Hunter
2020-02-21 5:44 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c39dbe9-a2b9-62e8-3a26-32cc747d0e60@gmail.com \
--to=digetx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=rlokhande@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).