From: William Qiu <william.qiu@starfivetech.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-mmc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] riscv: dts: starfive: Add mmc node
Date: Fri, 9 Dec 2022 19:31:07 +0800 [thread overview]
Message-ID: <8c40646b-3422-c2f5-49c3-60a2beefbcff@starfivetech.com> (raw)
In-Reply-To: <CACRpkdbjaiDhPcVH115w25oxseWrz=Yb-ugkmCOiqhRDmDZj5A@mail.gmail.com>
On 2022/12/9 5:15, Linus Walleij wrote:
> Hi William,
>
> thanks for your patch!
>
> On Wed, Dec 7, 2022 at 2:17 PM William Qiu <william.qiu@starfivetech.com> wrote:
>
>> + starfive,sys-syscon = <&sys_syscon 0x14 0x1a 0x7c000000>;
> (...)
>> + starfive,sys-syscon = <&sys_syscon 0x9c 0x1 0x3e>;
>
> These are registster offsets and shifts. Don't define such stuff in your device
> tree, use #defines in the code and just provide the phandle.
>
Hi Linus,
I will use #define in code instead in device tree.
Thank you for taking time to review and provide helpful comments for this patch.
Best Regards,
William Qiu
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2022-12-09 11:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 13:17 [PATCH v1 0/3] StarFive's SDIO/eMMC driver support William Qiu
2022-12-07 13:17 ` [PATCH v1 1/3] dt-bindings: mmc: Add bindings for StarFive William Qiu
2022-12-07 14:19 ` Rob Herring
2022-12-07 14:46 ` Conor Dooley
2022-12-08 8:38 ` William Qiu
2022-12-08 8:34 ` William Qiu
2022-12-07 15:13 ` Krzysztof Kozlowski
2022-12-08 8:44 ` William Qiu
2022-12-08 9:01 ` Krzysztof Kozlowski
2022-12-08 10:02 ` William Qiu
2022-12-08 21:13 ` Linus Walleij
2022-12-09 11:18 ` William Qiu
2022-12-07 13:17 ` [PATCH v1 2/3] mmc: starfive: Add sdio/emmc driver support William Qiu
2022-12-08 21:09 ` Linus Walleij
2022-12-09 11:26 ` William Qiu
2023-02-02 11:09 ` William Qiu
2023-02-02 12:51 ` Linus Walleij
2022-12-13 2:24 ` Shawn Lin
2022-12-13 7:21 ` William Qiu
2022-12-13 7:33 ` Shawn Lin
2022-12-13 7:38 ` William Qiu
2022-12-07 13:17 ` [PATCH v1 3/3] riscv: dts: starfive: Add mmc node William Qiu
2022-12-07 15:14 ` Krzysztof Kozlowski
2022-12-07 16:31 ` Conor Dooley
2022-12-08 9:57 ` William Qiu
2022-12-08 9:46 ` William Qiu
2022-12-08 21:15 ` Linus Walleij
2022-12-09 11:31 ` William Qiu [this message]
2023-01-16 10:13 ` William Qiu
2022-12-16 2:02 ` [PATCH v1 0/3] StarFive's SDIO/eMMC driver support William Qiu
2022-12-16 9:22 ` Ulf Hansson
2022-12-16 9:26 ` William Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c40646b-3422-c2f5-49c3-60a2beefbcff@starfivetech.com \
--to=william.qiu@starfivetech.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).