From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
Marijn Suijten <marijn.suijten@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: cache: qcom,llcc: Fix SM8550 description
Date: Wed, 17 May 2023 15:20:45 +0200 [thread overview]
Message-ID: <8c494c69-b92f-5eb0-0151-04d787b405c5@linaro.org> (raw)
In-Reply-To: <20230517054428.GH4868@thinkpad>
On 17.05.2023 07:44, Manivannan Sadhasivam wrote:
> On Wed, May 17, 2023 at 04:18:49AM +0200, Konrad Dybcio wrote:
>> SM8550 (LLCCv4.1) has 4 register regions, this was not described
>> between its addition and the restructurization that happened in
>> the commit referenced in the fixes tag.
>>
>> Fix it.
>>
>> Fixes: 43aa006e074c ("dt-bindings: arm: msm: Fix register regions used for LLCC banks")
>
> I'm not sure if the Fixes tag should point to the patch adding SM8550 support or
> the restructuring patch.
Right.. I wanted to add *some* fixes tag (clearly a bugfix)
and decided this one (and the one in patch 2) were the least bad
options, as the cleanup landed after/parallel to 8550 introduction.
Konrad
>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> But the change LGTM!
>
> Acked-by: Manivannan Sadhasivam <mani@kernel.org>
>
> - Mani
>
>> ---
>> Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
>> index d8b91944180a..44892aa589fd 100644
>> --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
>> +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
>> @@ -129,6 +129,7 @@ allOf:
>> - qcom,sm8250-llcc
>> - qcom,sm8350-llcc
>> - qcom,sm8450-llcc
>> + - qcom,sm8550-llcc
>> then:
>> properties:
>> reg:
>>
>> --
>> 2.40.1
>>
>
next prev parent reply other threads:[~2023-05-17 13:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 2:18 [PATCH 0/2] Fix SM8550 LLCC Konrad Dybcio
2023-05-17 2:18 ` [PATCH 1/2] dt-bindings: cache: qcom,llcc: Fix SM8550 description Konrad Dybcio
2023-05-17 5:44 ` Manivannan Sadhasivam
2023-05-17 13:20 ` Konrad Dybcio [this message]
2023-05-17 7:52 ` Krzysztof Kozlowski
2023-05-17 8:46 ` Krzysztof Kozlowski
2023-05-17 2:18 ` [PATCH 2/2] arm64: dts: qcom: sm8550: Use the correct LLCC register scheme Konrad Dybcio
2023-05-17 5:47 ` Manivannan Sadhasivam
2023-05-25 4:53 ` (subset) [PATCH 0/2] Fix SM8550 LLCC Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c494c69-b92f-5eb0-0151-04d787b405c5@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bp@alien8.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).