From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18353C77B75 for ; Wed, 17 May 2023 13:21:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231463AbjEQNVL (ORCPT ); Wed, 17 May 2023 09:21:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231696AbjEQNVK (ORCPT ); Wed, 17 May 2023 09:21:10 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B9BC7EC5 for ; Wed, 17 May 2023 06:20:49 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2ac82912a59so7301351fa.3 for ; Wed, 17 May 2023 06:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684329648; x=1686921648; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9ehNOHVJkggrK0SaUOOYHiCX3C3ML4esA8k2eVqxZzM=; b=F3t89XAqk/FSUiDRzyyIK/kIC97g87ZS8MYUNGXMZk+4NeKTnoQVJXPczjD7AnCxlw rV+ucXtji6cNqKqYyF14BhraI7CMUJe1uh/H+CC22l+CV7e3fvmbWkwxQxqlKo6CimBm PeVOvJcYAi3MORTJsv0Z4NsOXt8zRkqwgdNk9P1N8xC39Id/xUlcLHRHJw/KSSD2GoWb sfw1N1f4EM0UBZFPA1tzX+hKzoRsoH0hOk2qwBR5TZubrGLktG2JtqOqeztCDe/g15gM iiLPfuO3QnrWPNYX6NWm+g6y5lVI+6un/kV5uxwxdRNXsvr41YN2nc+WDaVGlHpKH2H5 I5JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684329648; x=1686921648; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9ehNOHVJkggrK0SaUOOYHiCX3C3ML4esA8k2eVqxZzM=; b=AWYjbAjexi96nkwKVDsp21oiNH+K7zGzT2SR+zQPzL0kvQYmWhs6vpIxQ/oJQ16E69 ZOEqwWuhefLYSMkCCrNDcPJTjuVHTXj94IWTM+Q2Dh+mi1ceXa5e/7kCuYhX+1dGAXOl HYqF+pkkF3M8ak3/Br9fL64azVVb9CXi/R9pl0D8o6lK5HKKxVHjoAIB2yPlNuwtVncz cy+PKNiTY0MiXVPoFz6c2jMzxounqr8eK4v378WlJjbB62PIl091/3ftNjwbKYZZu97S YU4y2JToR7s9foosqvJjr9sxRXJAYHsAMtmY0FFyKnWd85d2zQ1HKxAiDYI3K/2BLTfr JQcQ== X-Gm-Message-State: AC+VfDy5lbFv4AcmqNujnX4J+6I4iwrSHqCyo7eEXmSWFpOooq9ICucs IZ0fofNjDxW9Qw/uw2mJalpECA== X-Google-Smtp-Source: ACHHUZ4AIKk3Qd6kcFbMXUNKWSBpviIi0noAmat4pgn9AB3daV4BPBvPch6e5LInHQgct3+4T7eA3g== X-Received: by 2002:a05:651c:1031:b0:2ae:e214:482f with SMTP id w17-20020a05651c103100b002aee214482fmr3339752ljm.52.1684329647839; Wed, 17 May 2023 06:20:47 -0700 (PDT) Received: from ?IPV6:2a00:f41:c93:874f:be7b:fb6c:26f9:307c? ([2a00:f41:c93:874f:be7b:fb6c:26f9:307c]) by smtp.gmail.com with ESMTPSA id h22-20020a2eb0f6000000b002ad8bccceb2sm4125619ljl.57.2023.05.17.06.20.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 06:20:47 -0700 (PDT) Message-ID: <8c494c69-b92f-5eb0-0151-04d787b405c5@linaro.org> Date: Wed, 17 May 2023 15:20:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] dt-bindings: cache: qcom,llcc: Fix SM8550 description Content-Language: en-US To: Manivannan Sadhasivam Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Borislav Petkov (AMD)" , Marijn Suijten , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230517-topic-kailua-llcc-v1-0-d57bd860c43e@linaro.org> <20230517-topic-kailua-llcc-v1-1-d57bd860c43e@linaro.org> <20230517054428.GH4868@thinkpad> From: Konrad Dybcio In-Reply-To: <20230517054428.GH4868@thinkpad> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17.05.2023 07:44, Manivannan Sadhasivam wrote: > On Wed, May 17, 2023 at 04:18:49AM +0200, Konrad Dybcio wrote: >> SM8550 (LLCCv4.1) has 4 register regions, this was not described >> between its addition and the restructurization that happened in >> the commit referenced in the fixes tag. >> >> Fix it. >> >> Fixes: 43aa006e074c ("dt-bindings: arm: msm: Fix register regions used for LLCC banks") > > I'm not sure if the Fixes tag should point to the patch adding SM8550 support or > the restructuring patch. Right.. I wanted to add *some* fixes tag (clearly a bugfix) and decided this one (and the one in patch 2) were the least bad options, as the cleanup landed after/parallel to 8550 introduction. Konrad > >> Signed-off-by: Konrad Dybcio > > But the change LGTM! > > Acked-by: Manivannan Sadhasivam > > - Mani > >> --- >> Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml >> index d8b91944180a..44892aa589fd 100644 >> --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml >> +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml >> @@ -129,6 +129,7 @@ allOf: >> - qcom,sm8250-llcc >> - qcom,sm8350-llcc >> - qcom,sm8450-llcc >> + - qcom,sm8550-llcc >> then: >> properties: >> reg: >> >> -- >> 2.40.1 >> >