From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC09AC35DE1 for ; Tue, 25 Feb 2020 13:05:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A12AA218AC for ; Tue, 25 Feb 2020 13:05:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Em9lWr5g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730051AbgBYNFt (ORCPT ); Tue, 25 Feb 2020 08:05:49 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:49288 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729193AbgBYNFt (ORCPT ); Tue, 25 Feb 2020 08:05:49 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 01PD0LHw123433; Tue, 25 Feb 2020 07:00:21 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1582635621; bh=n4t+iSnVQ8VDVIb2I48j7hH+y8NZ1XyrKycrJ1RQK90=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=Em9lWr5gFGAJGIVefw5xY+a+Dwwp3Pn1zqurQTmTa86QzSJfB61woe0HHUX/g8ehS XLAlCnUyKrUCjo5oq/k/ku4iF5vXr4pkDEUhadl/PRi+CaazR50RDc2zCa/81FX0cB wuXtBSeggje7gf1NyIoD0IKvmhnN45jt4LHXNtzo= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 01PD0LKB096983 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Feb 2020 07:00:21 -0600 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Tue, 25 Feb 2020 07:00:20 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Tue, 25 Feb 2020 07:00:20 -0600 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 01PD0KFe036379; Tue, 25 Feb 2020 07:00:20 -0600 Subject: Re: [PATCH 1/4] dt-bindings: leds: Add a binding for AXP813 charger led To: Ondrej Jirman , , Jacek Anaszewski , Pavel Machek , Rob Herring , Chen-Yu Tsai , Maxime Ripard CC: Mark Rutland , Lee Jones , , , , References: <20200223131435.681620-1-megous@megous.com> <20200223131435.681620-2-megous@megous.com> From: Dan Murphy Message-ID: <8c4b9ef7-0c18-d5c1-9672-b7fc683c3ce9@ti.com> Date: Tue, 25 Feb 2020 06:55:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200223131435.681620-2-megous@megous.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Ondrej On 2/23/20 7:14 AM, Ondrej Jirman wrote: > The AXP813 PMIC can control one LED. Add binding to represent the LED. > > Signed-off-by: Ondrej Jirman > --- > .../devicetree/bindings/leds/leds-axp20x.yaml | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml > > diff --git a/Documentation/devicetree/bindings/leds/leds-axp20x.yaml b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml > new file mode 100644 > index 0000000000000..79282d55764bf > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml > @@ -0,0 +1,24 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-axp20x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LED driver for AXP813 PMIC from X-Powers. > + > +maintainers: > + - Ondrej Jirman > + > +description: | > + This module is part of the AXP20x MFD device. For more details > + see Documentation/devicetree/bindings/mfd/axp20x.txt. > + > + The LED controller is represented as a sub-node of the PMIC node on > + the device tree. > + > +properties: > + compatible: > + const: x-powers,axp813-charger-led > + > +required: > + - compatible You need to add the color and function properties for proper LED device name presentation per the bindings/leds/common.yaml binding. Dan