From: Stephen Boyd <sboyd@kernel.org>
To: Jishnu Prakash <quic_jprakash@quicinc.com>,
agross@kernel.org, devicetree@vger.kernel.org,
gregkh@linuxfoundation.org, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, quic_collinsd@quicinc.com,
quic_kamalw@quicinc.com, quic_subbaram@quicinc.com,
robh+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org,
Jishnu Prakash <quic_jprakash@quicinc.com>
Subject: Re: [PATCH] spmi: Add a check for remove callback when removing a SPMI driver
Date: Wed, 12 Apr 2023 21:15:39 -0700 [thread overview]
Message-ID: <8c774af24fa89d44924998064a996a2c.sboyd@kernel.org> (raw)
In-Reply-To: <1671601032-18397-2-git-send-email-quic_jprakash@quicinc.com>
Quoting Jishnu Prakash (2022-12-20 21:37:12)
> When removing a SPMI driver, there can be a crash due to NULL pointer
> dereference if it does not have a remove callback defined. This is
> one such call trace observed when removing the QCOM SPMI PMIC driver:
>
> dump_backtrace.cfi_jt+0x0/0x8
> dump_stack_lvl+0xd8/0x16c
> panic+0x188/0x498
> __cfi_slowpath+0x0/0x214
> __cfi_slowpath+0x1dc/0x214
> spmi_drv_remove+0x16c/0x1e0
> device_release_driver_internal+0x468/0x79c
> driver_detach+0x11c/0x1a0
> bus_remove_driver+0xc4/0x124
> driver_unregister+0x58/0x84
> cleanup_module+0x1c/0xc24 [qcom_spmi_pmic]
> __do_sys_delete_module+0x3ec/0x53c
> __arm64_sys_delete_module+0x18/0x28
> el0_svc_common+0xdc/0x294
> el0_svc+0x38/0x9c
> el0_sync_handler+0x8c/0xf0
> el0_sync+0x1b4/0x1c0
>
> If a driver has all its resources allocated through devm_() APIs and
> does not need any other explicit cleanup, it would not require a
> remove callback to be defined. Hence, add a check for remove callback
> presence before calling it when removing a SPMI driver.
>
> Signed-off-by: Jishnu Prakash <quic_jprakash@quicinc.com>
> ---
Applied to spmi-next
prev parent reply other threads:[~2023-04-13 4:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 5:37 [PATCH] Add a check for remove callback in spmi driver removal API Jishnu Prakash
2022-12-21 5:37 ` [PATCH] spmi: Add a check for remove callback when removing a SPMI driver Jishnu Prakash
2023-04-13 4:15 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c774af24fa89d44924998064a996a2c.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_collinsd@quicinc.com \
--cc=quic_jprakash@quicinc.com \
--cc=quic_kamalw@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).