Re: [PATCH 0/3] ADF41513/ADF41510 PLL frequency synthesizers

["Nuno Sá" <noname.nuno@gmail.com>]

On Sun, 2025-11-16 at 16:10 +0000, Jonathan Cameron wrote:
> On Mon, 10 Nov 2025 15:44:43 +0000
> Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org> wrote:
> 
> > This patch series adds support for the Analog Devices ADF41513 and ADF41510
> > ultralow noise PLL frequency synthesizers. These devices are designed for
> > implementing local oscillators (LOs) in high-frequency applications.
> > 
> > The ADF41513 covers frequencies from 1 GHz to 26.5 GHz, while the ADF41510
> > operates from 1 GHz to 10 GHz. Both devices feature exceptional phase noise
> > performance and flexible frequency synthesis capabilities.
> > 
> > Key features supported by this driver:
> > - Integer-N and fractional-N operation modes
> > - Ultra-low phase noise (-235 dBc/Hz integer-N, -231 dBc/Hz fractional-N)
> > - High maximum PFD frequency (250 MHz integer-N, 125 MHz fractional-N)
> > - 25-bit fixed modulus or 49-bit variable modulus fractional modes
> > - Programmable charge pump currents with 16x range
> > - Digital lock detect functionality
> > - Phase resync capability for consistent output phase
> > - Clock framework integration for system clock generation
> > 
> > The series includes:
> > 1. Core driver implementation with full register programming support
> > 2. Device tree bindings documentation
> > 3. IIO subsystem documentation with usage examples
> > 
> > The driver integrates with both the IIO subsystem (for direct hardware control)
> > and the Linux clock framework (for use as a system clock source), providing
> > flexibility for different use cases.
> 
> For v2, provide a little more info on why we need both interface types
> specifically what you can do with IIO that you can't do with a clock
> driver.  Also +CC the clk driver folk and list from MAINTAINERS.
> 
> We have evolved to this dual interface state drivers, but I'm not sure
> we aren't in a case 'If we were doing this again we'd never start from
> here.'

Yeah, in some devices I do think that we should likely only have the clock driver
(for devices where we only control the channel frequency). For others, we do have
offer more control through IIO which adds some value.

- Nuno Sá

> 
> Jonathan
> 
> 
> > 
> > Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
> > ---
> > Rodrigo Alencar (3):
> >       iio: frequency: adf41513: driver implementation
> >       dt-bindings: iio: frequency: add adf41513
> >       docs: iio: add documentation for adf41513 driver
> > 
> >  .../bindings/iio/frequency/adi,adf41513.yaml       |  268 ++++
> >  Documentation/iio/adf41513.rst                     |  377 +++++
> >  Documentation/iio/index.rst                        |    1 +
> >  MAINTAINERS                                        |    9 +
> >  drivers/iio/frequency/Kconfig                      |   11 +
> >  drivers/iio/frequency/Makefile                     |    1 +
> >  drivers/iio/frequency/adf41513.c                   | 1435 ++++++++++++++++++++
> >  7 files changed, 2102 insertions(+)
> > ---
> > base-commit: d16d1c2553248f9b859b86c94344d8b81f0297cd
> > change-id: 20251110-adf41513-iio-driver-aaca8a7f808e
> > 
> > Best regards,