Re: [PATCH 1/1] dt-bindings: interrupt-controller: convert fsl,ls-scfg-msi to yaml

[Krzysztof Kozlowski <krzk@kernel.org>]

On 25/06/2024 22:10, Frank Li wrote:
> Convert device tree binding fsl,ls-scfg-msi to yaml format.
> 
> Additional changes:
> - Include gic.h and use predefined macro in example.
> - Remove label in example.
> - Change node name to interrupt-controller in example.
> - Fix error in example.
> - ls1046a allow 4 irqs, other platform only 1 irq.
> 


> +
> +properties:
> +  compatible:
> +    enum:
> +      - fsl,ls1021a-msi
> +      - fsl,ls1043a-msi
> +      - fsl,ls1046a-msi
> +      - fsl,ls1043a-v1.1-msi
> +      - fsl,ls1012a-msi

Keep the list ordered alpha-numerically.

> +
> +  reg:
> +    maxItems: 1
> +
> +  msi-controller: true

No msi-cells?

> +
> +  interrupts:
> +    minItems: 1
> +    maxItems: 4

Please describe the interrupts (items: - description: ...)

> +
> +required:
> +  - compatible
> +  - reg
> +  - msi-controller
> +  - interrupts
> +
> +additionalProperties: false

This goes after allOf: block.

> +
> +allOf:

No $ref to msi-controller.yaml?

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,ls1046a-msi
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 4
> +    else:
> +      properties:
> +        interrupts:
> +          maxItems: 1
Best regards,
Krzysztof