From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
~postmarketos/upstreaming@lists.sr.ht
Cc: martin.botka@somainline.org,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/23] ARM: dts: qcom-msm8974: Remove properties that are always overriden
Date: Mon, 18 Apr 2022 14:33:15 +0200 [thread overview]
Message-ID: <8c880b7a-ddb8-dea1-40c1-892247c6439d@linaro.org> (raw)
In-Reply-To: <20220415115633.575010-3-konrad.dybcio@somainline.org>
On 15/04/2022 13:56, Konrad Dybcio wrote:
> Model and compatible are set per-device, so having them in the SoC DTSI is
> superfluous. Remove them.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> arch/arm/boot/dts/qcom-msm8974.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 412d94736c35..e216630a1d02 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -12,8 +12,6 @@
> / {
> #address-cells = <1>;
> #size-cells = <1>;
> - model = "Qualcomm MSM8974";
> - compatible = "qcom,msm8974";
The compatible by convention is in the DTSI, even if it is not actually
used, it gives clear information what is the expected fallback.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-18 12:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220415115633.575010-1-konrad.dybcio@somainline.org>
2022-04-15 11:56 ` [PATCH 01/23] ARM: dts: qcom-*-sony*: Mention SONY board names in DT filenames Konrad Dybcio
2022-04-21 14:26 ` Bjorn Andersson
2022-04-15 11:56 ` [PATCH 02/23] ARM: dts: qcom-msm8974: Remove properties that are always overriden Konrad Dybcio
2022-04-18 12:33 ` Krzysztof Kozlowski [this message]
2022-04-15 11:56 ` [PATCH 03/23] ARM: dts: qcom-msm8974*: Fix UART naming Konrad Dybcio
2022-04-15 11:56 ` [PATCH 04/23] ARM: dts: qcom-msm8974*: Fix I2C labels Konrad Dybcio
2022-04-18 12:34 ` Krzysztof Kozlowski
2022-04-15 11:56 ` [PATCH 05/23] ARM: dts: qcom-msm8974: Fix up mdss nodes Konrad Dybcio
2022-04-15 11:56 ` [PATCH 06/23] ARM: dts: qcom-msm8974: Fix up SDHCI nodes Konrad Dybcio
2022-04-15 11:56 ` [PATCH 07/23] ARM: dts: qcom-msm8974*: Rename msmgpio to tlmm Konrad Dybcio
2022-04-15 11:56 ` [PATCH 08/23] ARM: dts: qcom-apq8074-dragonboard: Use &labels Konrad Dybcio
2022-04-15 11:56 ` [PATCH 09/23] ARM: dts: qcom-msm8974-fp2: " Konrad Dybcio
2022-04-18 12:36 ` Krzysztof Kozlowski
2022-04-15 11:56 ` [PATCH 10/23] ARM: dts: qcom-msm8974-lge-nexus5: " Konrad Dybcio
2022-04-15 11:56 ` [PATCH 11/23] ARM: dts: qcom-msm8974-klte: " Konrad Dybcio
2022-04-15 11:56 ` [PATCH 12/23] ARM: dts: qcom-msm8974-{"hon","am"}ami: Commonize and modernize the DTs Konrad Dybcio
2022-04-15 11:56 ` [PATCH 13/23] ARM: dts: qcom-msm8974-castor: Use &labels Konrad Dybcio
2022-04-15 11:56 ` [PATCH 14/23] ARM: dts: qcom-msm8974pro: " Konrad Dybcio
2022-04-15 11:56 ` [PATCH 15/23] ARM: dts: qcom-msm8974pro-*: Use the 8974pro name in DT filenames Konrad Dybcio
2022-04-15 11:56 ` [PATCH 16/23] ARM: dts: qcom-msm8974: Convert ADSP to a MMIO device Konrad Dybcio
2022-04-15 11:56 ` [PATCH 17/23] ARM: dts: qcom-msm8974: Sort and clean up nodes Konrad Dybcio
2022-04-15 11:56 ` [PATCH 18/23] ARM: dts: qcom-msm8974*: Enable IMEM unconditionally Konrad Dybcio
2022-04-15 11:56 ` [PATCH 19/23] ARM: dts: qcom-msm8974*: Consolidate I2C/UART/SDHCI Konrad Dybcio
2022-04-15 11:56 ` [PATCH 20/23] ARM: dts: qcom-msm8974*: Clean up old GPIO declarations Konrad Dybcio
2022-04-15 11:56 ` [PATCH 21/23] ARM: dts: qcom-msm8974-rhine: Add NFC and enable I2C hosts Konrad Dybcio
2022-04-15 11:56 ` [PATCH 22/23] ARM: dts: qcom-msm8974-rhine: Add pstore node Konrad Dybcio
2022-04-15 11:56 ` [PATCH 23/23] ARM: dts: qcom-msm8974*: Remove unnecessary include Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c880b7a-ddb8-dea1-40c1-892247c6439d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).