From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EECC7C6FD1C for ; Fri, 24 Mar 2023 20:47:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232123AbjCXUra (ORCPT ); Fri, 24 Mar 2023 16:47:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231950AbjCXUr3 (ORCPT ); Fri, 24 Mar 2023 16:47:29 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED375196B9 for ; Fri, 24 Mar 2023 13:47:27 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id ek18so12623421edb.6 for ; Fri, 24 Mar 2023 13:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679690846; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gvJuFk30qXvHsXmKvq2WXms+VNACf251BO2nmorEuAE=; b=TPOAgzMTYkViLIjcHeqRkpM16OmWLnnbSWgzEmaWJhwgv6eN1kJDftmvs1qIr3Lpic ypGfjEotaFTMZpJBjFijOTrxiGbMN2vhUX+dyTqFbm9U1NI7mTwp+TM2X5IMrdIYObb1 QCB0JNg9jdvMvi2jimAXGw/rrnK/mikPXCPcvazVy+qiYekvbuqavaUQ/HBEhUDPcfeE 7U0QDgpID8b7+iN+jfwEGzyC+OIPybCaixweKOBhBIL+6sbMSCDxbkuom5nH3Z/kZUh+ 1us+I2Is9gmKVZRbqsGTsU7zIVTW+rzj5UdwTPuf4VFL+OpMXhvvqEwbP2xCCabM8XtZ sAyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679690846; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gvJuFk30qXvHsXmKvq2WXms+VNACf251BO2nmorEuAE=; b=X96RGeRyHEyBM2nxghlfZGy2V0QgfRdlzJMPzUC5a93ozpbgcoHA66ZKDmZtQqh/9s XQeaUFEu3C4j8fvH1foZKyMXsvqF0fgtBx8fyRrEkhSjUZoEBwcT18yppMPSHaSGdfnN LWcOAjQ2c/X8F0VQ6iDdSxkESzSUC2rKg1dgMs7D9xEipxXUCldPo3rdigMPbGVhyfxQ ymlOztxiT7VIdVnsCE/D2KpYasyBfy3TwwvCx7OFQl7tPheLK+8Y6QZOhnBWF0sVetMp Uza1WhRc1ZD7udaX8N8LN6PhZl1ujkvHmge5cgxtP2WAS3BZ0FsU174sM+azBCFJvkI3 MktQ== X-Gm-Message-State: AAQBX9d9rPREgeXn+qx1w2tiv61qQmNhJHOymwoJpI1Acob5vY8iC7a7 6Xsip8lnlcCtMNNTHlwaB8AKgw== X-Google-Smtp-Source: AKy350YwCpEJ2Rxx3nxkTYvfEOr50qMbvXpKHh3yxBpw2u57GGoC30mDM0iDbjcLJi0wu6059ATpFA== X-Received: by 2002:a17:906:b049:b0:937:9a24:370b with SMTP id bj9-20020a170906b04900b009379a24370bmr4185300ejb.67.1679690846477; Fri, 24 Mar 2023 13:47:26 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:3027:fb0b:ae08:588? ([2a02:810d:15c0:828:3027:fb0b:ae08:588]) by smtp.gmail.com with ESMTPSA id v15-20020a170906858f00b0093229e527cdsm10307455ejx.42.2023.03.24.13.47.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 13:47:26 -0700 (PDT) Message-ID: <8c88fe1b-cb91-22e3-6fcd-c2fdf2202cc0@linaro.org> Date: Fri, 24 Mar 2023 21:47:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes Content-Language: en-US To: Bjorn Andersson Cc: Neil Armstrong , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v2-0-0ca1bea1a843@linaro.org> <20230323-topic-sm8450-upstream-dt-bindings-fixes-v2-2-0ca1bea1a843@linaro.org> <20230324174518.2arvdglqqixmxqcp@ripper> <20230324195713.5blwpv7xjijlrtt5@ripper> From: Krzysztof Kozlowski In-Reply-To: <20230324195713.5blwpv7xjijlrtt5@ripper> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/03/2023 20:57, Bjorn Andersson wrote: > On Fri, Mar 24, 2023 at 08:27:12PM +0100, Krzysztof Kozlowski wrote: >> On 24/03/2023 18:45, Bjorn Andersson wrote: >>> On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: >>>> Fixes the following DT bindings check error: >>> >>> Is that because idle-state-name and local-timer-stop should not be >>> defined for domain-idle-states or are you just clearing out the >>> dtbs_check warning? >>> >>> According to cpu-capacity.txt local-timer-stop seems to have been a >>> property relevant for clusters in the past, was this a mistake in the >>> binding or did something change when this was moved to >>> domain-idle-states? >> >> I cannot find anything about local-timer-stop in cpu-capacity.txt. Where >> do you see it? >> > > Ohh, you're right it's only mentioned in the example. > > But idle-states.yaml documents the property for both cpus and clusters, > and it's used throughout the examples. > > Our cluster states are defined in domanin-idle-states instead of > idle-state, does this imply that the flag is no longer applicable > per cluster in this mode of operation? As you noticed their meaning is interleaving. For example on SC7280 we use arm,idle-state for cluster. But other Qualcomm platforms rather define clusters as domain-idle-states and in that case, nothing parses tgat flag. The flag is only for cpuidle dt_idle_states. For power-domains it was always ignored. Funny fact - both cpu/cluster idle-states and power-domain-idle-states will end up eventually in cpuidle-psci.c... Best regards, Krzysztof