From: Claudius Heine <ch@denx.de>
To: Jagan Teki <jagan@amarulasolutions.com>,
Rob Herring <robh+dt@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Sam Ravnborg <sam@ravnborg.org>
Cc: Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-amarula@amarulasolutions.com
Subject: Re: [PATCH v3 2/2] drm: bridge: Add TI SN65DSI83/84/85 DSI to LVDS bridge
Date: Wed, 24 Mar 2021 14:21:50 +0100 [thread overview]
Message-ID: <8cac7848-3a8e-c597-1efc-c67fb6daba25@denx.de> (raw)
In-Reply-To: <20210214174453.104616-2-jagan@amarulasolutions.com>
Hi Jagan,
On 2021-02-14 18:44, Jagan Teki wrote:
[...]
> +static void sn65dsi_enable(struct drm_bridge *bridge)
> +{
> + struct sn65dsi *sn = bridge_to_sn65dsi(bridge);
> + struct drm_display_mode *mode = bridge_to_mode(bridge);
> + int bpp = mipi_dsi_pixel_format_to_bpp(sn->dsi->format);
> + unsigned int lanes = sn->dsi->lanes;
> + unsigned int pixel_clk = mode->clock * 1000;
> + unsigned int dsi_clk = pixel_clk * bpp / (lanes * 2);
> + unsigned int val;
> +
> + /* reset SOFT_RESET bit */
> + regmap_write(sn->regmap, SN65DSI_SOFT_RESET, 0x0);
> +
> + msleep(10);
> +
> + /* reset PLL_EN bit */
> + regmap_write(sn->regmap, SN65DSI_CLK_PLL, 0x0);
> +
> + msleep(10);
> +
> + /* setup lvds clock */
> + val = sn65dsi_get_clk_range(0, 5, pixel_clk, 25000000, 25000000);
> + if (val < 0) {
val is unsigned int, so it can never be negative so this condition is
always false. Same error further down in that function as well.
regards,
Claudius
next prev parent reply other threads:[~2021-03-24 13:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 17:44 [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85 Jagan Teki
2021-02-14 17:44 ` [PATCH v3 2/2] drm: bridge: Add TI SN65DSI83/84/85 DSI to LVDS bridge Jagan Teki
2021-02-14 18:43 ` kernel test robot
2021-03-05 21:51 ` Marek Vasut
2021-03-24 13:21 ` Claudius Heine [this message]
2021-02-15 9:02 ` [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85 Neil Armstrong
2021-02-15 11:25 ` Jagan Teki
2021-02-15 16:49 ` Neil Armstrong
2021-03-05 21:36 ` Rob Herring
2021-03-05 21:43 ` Marek Vasut
2021-03-24 13:56 ` Claudius Heine
2021-04-07 10:04 ` ch
2021-04-08 14:45 ` Jagan Teki
2021-04-21 22:34 ` Marek Vasut
2021-04-22 8:10 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cac7848-3a8e-c597-1efc-c67fb6daba25@denx.de \
--to=ch@denx.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).