From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC37C77B61 for ; Mon, 24 Apr 2023 18:17:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231802AbjDXSRd (ORCPT ); Mon, 24 Apr 2023 14:17:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231499AbjDXSRc (ORCPT ); Mon, 24 Apr 2023 14:17:32 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC585A5C2; Mon, 24 Apr 2023 11:17:02 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-63b64a32fd2so6486092b3a.2; Mon, 24 Apr 2023 11:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682360222; x=1684952222; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=H4jpD+0lOC76rH99UvClr3/xF+i6hb/rLXs4X6IWyWs=; b=QIPeXC4jltT7/4WYGrzKIVDR+5t2x0I4ktVMVbEMrkNwDV6fQVfhU5xM7uoMFFqbUL o7uPorQh8h4ypnFph3M+wMrwqf6qSCSAzuyEhDOcSS4ccMNj+IjMYn6YJeNuzxRODdC4 Qu/0zByG8IiCk709QAsMmDFUZCfSXNCnNsG4D8JbccYF7dgaTADSG+BlsviSVixAT9Cq XZ7+uMceJPu4T6X5ckKdIQEPs7Qorv/r8pp0r41HcmNV3FrpzNATvk3BYj0GKJoBoi6K zeNO+4a+vvsNtbpDkRzcI/gLhqkRipZy3fMklHa5XGioxWbDxvlmpTJWC6oPA6hI8M9S eHoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682360222; x=1684952222; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H4jpD+0lOC76rH99UvClr3/xF+i6hb/rLXs4X6IWyWs=; b=h1dZ5kH++BjQa+rv1Ohttzul+MNGY5eBieEu9vevHD3VpVz9UhRk6aWDkfQwxxf50J 74JeKX+mA+jk6FWQ5XjPxRK+XVsmul+rNBttiJ7q8JGeHksktsEvSSbIqkJPnatoErr3 F+S2ZCRHTpqosc3LJYVFEUfjqvfx2oUIU85Axkf0HoJWtJSj0z+bw3hf4PdztASGeAwh g5C6bZjawlYmjOfaHIBZIZbY78r97r+ST9KTDqB8m278jdiqqrmj7QZ++kdxVCwCBssZ Xb9yknX7VYyDXzmSYOUpvOACLEJ+pT+LQd3efrjwPWiXcqhw8OTsbDk+e18EMwMh9nSK XPCA== X-Gm-Message-State: AAQBX9fNK0QUnbCPKCfjtyLQ7KB8h2sZsV6qkfkGcbHQqOpzGeXu11X4 p/PhdpTo00/xpNkfHnqCfSY= X-Google-Smtp-Source: AKy350ZEJp+tXoj2zx+EUvJDSy7p4UR1enEVI+rM/GeLTTiRNS5bDnOjRaAqwuLkpBRktmd+Mj50Mw== X-Received: by 2002:a05:6a20:a111:b0:f3:ae06:c4e6 with SMTP id q17-20020a056a20a11100b000f3ae06c4e6mr6588752pzk.6.1682360221838; Mon, 24 Apr 2023 11:17:01 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id p19-20020a056a000b5300b0063b1b84d54csm2862604pfo.213.2023.04.24.11.16.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Apr 2023 11:17:01 -0700 (PDT) Message-ID: <8cddf126-d410-aac1-a92d-d15e2fd4b66b@gmail.com> Date: Mon, 24 Apr 2023 11:16:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH net-next 1/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller Content-Language: en-US To: Justin Chen , Krzysztof Kozlowski Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, bcm-kernel-feedback-list@broadcom.com, justin.chen@broadcom.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, opendmb@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, richardcochran@gmail.com, sumit.semwal@linaro.org, christian.koenig@amd.com References: <1681863018-28006-1-git-send-email-justinpopo6@gmail.com> <1681863018-28006-2-git-send-email-justinpopo6@gmail.com> From: Florian Fainelli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 4/24/23 11:14, Justin Chen wrote: > On Fri, Apr 21, 2023 at 12:29 AM Krzysztof Kozlowski > wrote: >> >> On 19/04/2023 02:10, Justin Chen wrote: >>> From: Florian Fainelli >>> >>> Add a binding document for the Broadcom ASP 2.0 Ethernet >>> controller. >>> >>> Signed-off-by: Florian Fainelli >>> Signed-off-by: Justin Chen >>> --- >>> .../devicetree/bindings/net/brcm,asp-v2.0.yaml | 146 +++++++++++++++++++++ >>> 1 file changed, 146 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml >>> new file mode 100644 >>> index 000000000000..3817d722244f >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml >>> @@ -0,0 +1,146 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: "http://devicetree.org/schemas/net/brcm,asp-v2.0.yaml#" >>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> >> Drop quotes. >> >>> + >>> +title: Broadcom ASP 2.0 Ethernet controller >>> + >>> +maintainers: >>> + - Justin Chen >>> + - Florian Fainelli >>> + >>> +description: Broadcom Ethernet controller first introduced with 72165 >>> + >>> +properties: >>> + '#address-cells': >>> + const: 1 >>> + '#size-cells': >>> + const: 1 >>> + >>> + compatible: >>> + enum: >>> + - brcm,bcm72165-asp-v2.0 >>> + - brcm,asp-v2.0 >>> + - brcm,asp-v2.1 >> >> Is this part of SoC? If so, then SoC compatibles are preferred, not IP >> block versions. > We have the same IP on different chips. So no, it isn't tied to a specific SoC. > >> >>> + >>> + reg: >>> + maxItems: 1 >>> + description: ASP registers >> >> Drop description. >> >>> + >>> + ranges: true >>> + >>> + interrupts: >>> + minItems: 1 >>> + items: >>> + - description: RX/TX interrupt >>> + - description: Port 0 Wake-on-LAN >>> + - description: Port 1 Wake-on-LAN >>> + >>> + clocks: >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >> >> Drop. >> >>> + description: Phandle to clock controller >> >> Drop. >> >> Instead maxItems. >> >>> + >>> + clock-names: >>> + const: sw_asp >> >> Drop entire property. >> >>> + >>> + ethernet-ports: >>> + type: object >>> + properties: >>> + '#address-cells': >>> + const: 1 >>> + '#size-cells': >>> + const: 0 >> >> Missing additionalProperties:false. Look at existing bindings how it is >> done. >> >>> + >>> + patternProperties: >>> + "^port@[0-9]+$": >>> + type: object >>> + >>> + $ref: ethernet-controller.yaml# >>> + >>> + properties: >>> + reg: >>> + maxItems: 1 >>> + description: Port number >>> + >>> + channel: >>> + maxItems: 1 >>> + description: ASP channel number >>> + >>> + required: >>> + - reg >>> + - channel >>> + >>> +patternProperties: >>> + "^mdio@[0-9a-f]+$": >>> + type: object >>> + $ref: "brcm,unimac-mdio.yaml" >>> + >>> + description: >>> + ASP internal UniMAC MDIO bus >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - interrupts >>> + - clocks >>> + - clock-names >>> + - ranges >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + asp@9c00000 { >> >> Node names should be generic. >> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation >> >>> + compatible = "brcm,asp-v2.0"; >>> + reg = <0x9c00000 0x1fff14>; >>> + interrupts = <0x0 0x33 0x4>; >> >> Use proper defines for flags. > Not understanding this comment. Can you elaborate? I believe Krzysztof would prefer that you use: interrupts = here, which would require using defined from include/dt-bindings/interrupt-controller/{arm-gic.h,irq.h} -- Florian