From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8D3C77B73 for ; Fri, 21 Apr 2023 03:28:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230258AbjDUD2H (ORCPT ); Thu, 20 Apr 2023 23:28:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230260AbjDUD2C (ORCPT ); Thu, 20 Apr 2023 23:28:02 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF8C91FCE; Thu, 20 Apr 2023 20:28:00 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 2B5D424E197; Fri, 21 Apr 2023 11:27:59 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 21 Apr 2023 11:27:55 +0800 Received: from [192.168.125.106] (113.72.144.253) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 21 Apr 2023 11:27:54 +0800 Message-ID: <8ce740ac-54e9-bf31-1e03-2f3e0e9ef63c@starfivetech.com> Date: Fri, 21 Apr 2023 11:27:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RESEND v2 4/6] soc: starfive: Extract JH7110 pmu private operations Content-Language: en-US To: Conor Dooley CC: Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , , , References: <20230419035646.43702-1-changhuang.liang@starfivetech.com> <20230419035646.43702-5-changhuang.liang@starfivetech.com> <20230419-atypical-unbounded-99cbbff3091a@spud> From: Changhuang Liang In-Reply-To: <20230419-atypical-unbounded-99cbbff3091a@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.144.253] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/4/20 1:47, Conor Dooley wrote: > On Tue, Apr 18, 2023 at 08:56:44PM -0700, Changhuang Liang wrote: >> Move JH7110 private operation into private data of compatible. >> Convenient to expand different compatible. > > I prefer how the code looks in v2, thanks. > However, just as in the prior patch, "Convenient to expand different > compatible" isn't really a justification - specifically, supporting the > power domain controller serving the dphy is your motivation here. The > important difference being that it uses a regmap from a syscon and has > no interrupts nor the encourage features. > So should I expand the commit message which called "in order to add the aon power domain" although the patch is applied behind current patch. > Although, given the only real similarity the code driving each of the > PMUs is the variable names, I guess you could argue that this driver > should be left alone and the "aon dphy" should be a different driver > altogether. > I have tried independent this aon pmu, but it code is very similar to the original pmu, so I think they can put together, reduce linux kernel bloat. > I don't have a strong opinion though & if it's fine with Walker and > noone else objects, it's fine with me...