From: Krzysztof Kozlowski <krzk@kernel.org>
To: "qinjian[覃健]" <qinjian@cqplus1.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"maz@kernel.org" <maz@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"broonie@kernel.org" <broonie@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"stefan.wahren@i2se.com" <stefan.wahren@i2se.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"Wells Lu 呂芳騰" <wells.lu@sunplus.com>,
"Rob Herring" <robh@kernel.org>
Subject: Re: [PATCH v9 02/10] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards
Date: Tue, 22 Feb 2022 08:51:33 +0100 [thread overview]
Message-ID: <8ce8a3db-0f42-0b30-6688-01c1ea905425@kernel.org> (raw)
In-Reply-To: <fd66d0c1f8d5410ca676dd523bcde61b@cqplus1.com>
On 22/02/2022 07:15, qinjian[覃健] wrote:
>>> +
>>> +properties:
>>> + $nodename:
>>> + const: '/'
>>> + compatible:
>>> + oneOf:
>>> + - items:
>>> + - const: sunplus,sp7021-achip
>>> +
>>
>> You did not publish DTS so bigger picture and context are missing here.
>> Is it a SoC compatible? A board compatible? Why only one? Against what
>> does it validate?
>>
>> This binding looks incomplete.
>
> Sunplus SP7021 is an ARM Cortex A7 based SoC.
> The patch is for SP7021 SoC and SP7021 based boards.
> Sorry, I don't understand your questions.
> Could you explain more?
You have there only one compatible but if I would expect at least two.
One for SoC and one for board. Something like this:
Documentation/devicetree/bindings/arm/rda.yaml
but in your case enum would have only one entry.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-22 7:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 3:29 [PATCH v9 00/10] Add Sunplus SP7021 SoC Support Qin Jian
2022-02-21 3:29 ` [PATCH v9 01/10] dt-bindings: vendor-prefixes: Add Sunplus Qin Jian
2022-02-21 3:29 ` [PATCH v9 02/10] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-02-21 16:29 ` Krzysztof Kozlowski
2022-02-22 6:15 ` qinjian[覃健]
2022-02-22 7:51 ` Krzysztof Kozlowski [this message]
2022-02-28 7:05 ` qinjian[覃健]
2022-02-28 8:40 ` Krzysztof Kozlowski
2022-03-01 2:08 ` qinjian[覃健]
2022-03-01 7:28 ` Krzysztof Kozlowski
2022-02-21 3:29 ` [PATCH v9 03/10] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-02-21 3:29 ` [PATCH v9 04/10] reset: Add Sunplus " Qin Jian
2022-02-21 3:29 ` [PATCH v9 05/10] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-02-22 14:22 ` Rob Herring
2022-02-23 11:34 ` Krzysztof Kozlowski
2022-02-28 6:31 ` qinjian[覃健]
2022-02-28 9:20 ` Krzysztof Kozlowski
2022-03-01 2:12 ` qinjian[覃健]
2022-02-21 3:29 ` [PATCH v9 06/10] clk: Add Sunplus " Qin Jian
2022-02-21 3:29 ` [PATCH v9 07/10] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-02-21 3:29 ` [PATCH v9 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-02-21 3:29 ` [PATCH v9 09/10] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-02-21 3:29 ` [PATCH v9 10/10] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ce8a3db-0f42-0b30-6688-01c1ea905425@kernel.org \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stefan.wahren@i2se.com \
--cc=tglx@linutronix.de \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).