From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Johan Hovold" <johan+linaro@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Abel Vesa <abel.vesa@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: qcom: Allow 'vddpe-3v3-supply' again
Date: Wed, 24 Jul 2024 15:22:32 +0200 [thread overview]
Message-ID: <8cef6a08-c363-43f1-8d55-ad47b399fe5e@kernel.org> (raw)
In-Reply-To: <20240723151328.684-1-johan+linaro@kernel.org>
On 23/07/2024 17:13, Johan Hovold wrote:
> Commit 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to
> dedicated schema") incorrectly removed 'vddpe-3v3-supply' from the
> bindings, which results in DT checker warnings like:
>
> arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb: pcie@600000: Unevaluated properties are not allowed ('vddpe-3v3-supply' was unexpected)
> from schema $id: http://devicetree.org/schemas/pci/qcom,pcie.yaml#
>
> Note that this property has been part of the Qualcomm PCIe bindings
> since 2018 and would need to be deprecated rather than simply removed if
> there is a desire to replace it with 'vpcie3v3' which is used for some
> non-Qualcomm controllers.
>
> Fixes: 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to dedicated schema")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Thanks. You could also mention in commit msg that Linux drivers for
msm8996, SM8[123456]50 and few others actually requested that supply. In
any case:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-24 13:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 15:13 [PATCH] dt-bindings: PCI: qcom: Allow 'vddpe-3v3-supply' again Johan Hovold
2024-07-24 13:22 ` Krzysztof Kozlowski [this message]
2024-07-24 17:22 ` Dmitry Baryshkov
2024-07-25 6:17 ` Johan Hovold
2024-07-25 7:49 ` Dmitry Baryshkov
2024-07-25 8:13 ` Johan Hovold
2024-07-25 8:57 ` Dmitry Baryshkov
2024-07-25 9:05 ` Johan Hovold
2024-07-25 10:24 ` Dmitry Baryshkov
2024-07-25 11:28 ` Johan Hovold
2024-08-22 9:07 ` Johan Hovold
2024-09-11 6:13 ` Johan Hovold
2024-09-11 13:51 ` Bjorn Helgaas
2024-09-11 13:57 ` Johan Hovold
2024-08-22 9:42 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cef6a08-c363-43f1-8d55-ad47b399fe5e@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).