From: Andrew Lunn <andrew@lunn.ch>
To: Parvathi Pudi <parvathi@couthit.com>
Cc: tony@atomide.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, richardcochran@gmail.com,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
danishanwar@ti.com, pratheesh@ti.com, prajith@ti.com,
vigneshr@ti.com, praneeth@ti.com, srk@ti.com, rogerq@ti.com,
krishna@couthit.com, mohan@couthit.com, pmohan@couthit.com,
basharath@couthit.com, "Andrew F . Davis" <afd@ti.com>,
Murali Karicheri <m-karicheri2@ti.com>
Subject: Re: [PATCH 1/2] arm: dts: ti: Adds device tree nodes for PRU Cores, IEP and eCAP modules of PRU-ICSS2 Instance.
Date: Mon, 13 Oct 2025 16:44:16 +0200 [thread overview]
Message-ID: <8cfc5ece-6c2e-48d9-a65c-3edbcc9edc39@lunn.ch> (raw)
In-Reply-To: <20251013125401.1435486-2-parvathi@couthit.com>
> + interrupt-names = "rx", "emac_ptp_tx",
> + "hsr_ptp_tx";
Something looks wrong with the indentation here. The same happens in
at least one other place.
> +&pruss2_mdio {
> + status = "okay";
> + pruss2_eth0_phy: ethernet-phy@0 {
> + reg = <0>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <30 IRQ_TYPE_EDGE_FALLING>;
> + };
> +
> + pruss2_eth1_phy: ethernet-phy@1 {
> + reg = <1>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
> + };
PHY interrupts are 99% level, not edge, because they represent an
interrupt controller in the PHY, and you need to clear all the
interrupts in the controller before it deasserts the interrupt pin.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-10-13 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 12:52 [PATCH 0/2] Add support for ICSSM Ethernet on AM57x, AM437x, and AM335x Parvathi Pudi
2025-10-13 12:52 ` [PATCH 1/2] arm: dts: ti: Adds device tree nodes for PRU Cores, IEP and eCAP modules of PRU-ICSS2 Instance Parvathi Pudi
2025-10-13 13:47 ` Anwar, Md Danish
2025-10-15 13:13 ` Parvathi Pudi
2025-10-13 14:44 ` Andrew Lunn [this message]
2025-10-15 13:29 ` Parvathi Pudi
2025-11-03 11:08 ` Parvathi Pudi
2025-10-13 12:52 ` [PATCH 2/2] arm: dts: ti: Adds support for AM335x and AM437x Parvathi Pudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cfc5ece-6c2e-48d9-a65c-3edbcc9edc39@lunn.ch \
--to=andrew@lunn.ch \
--cc=afd@ti.com \
--cc=basharath@couthit.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krishna@couthit.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mohan@couthit.com \
--cc=netdev@vger.kernel.org \
--cc=parvathi@couthit.com \
--cc=pmohan@couthit.com \
--cc=prajith@ti.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=rogerq@ti.com \
--cc=srk@ti.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).