From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0853CC433EF for ; Thu, 7 Apr 2022 07:48:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232682AbiDGHuz (ORCPT ); Thu, 7 Apr 2022 03:50:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242188AbiDGHux (ORCPT ); Thu, 7 Apr 2022 03:50:53 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97AB885970 for ; Thu, 7 Apr 2022 00:48:52 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id c42so5410658edf.3 for ; Thu, 07 Apr 2022 00:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=7eOOLrAKkfSspaBOmVeWY/1P1p3w24BPhUI3ADFJBCI=; b=sogAdtsAFC5HCuOZDlP9hCKRUcFarSAAFtArxcpakHbjtI+H6rlxyAdZEWFLiv3Ew0 ZiX/ecvjddUhTtCRabR7BgUoqBDDKxzxu5kKlGDuxPv1RYCalrkCJ7aDGWwQ0oKQG+H+ wWrk8gsx7JZHJSziIF4YYk+huAMheAeS92FXTkdOAdHYrU1ZfJCa41bjAIpJY8/gBI5x Z13miNyaXnegSrvQi6qzse8DCg5Q1LotTJtkFOgzarqJI5gapKutHVVGlw2tnrrBMbrE rQnYTR14EEKGq61ygs7BSzBZejgH0+DC+46oXgFRHZQWkpr53Q08n05BcMKaE7MQPMb6 HtQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7eOOLrAKkfSspaBOmVeWY/1P1p3w24BPhUI3ADFJBCI=; b=2To5twJwelxs5MRwqceq5e0wRXA4e6T5woA1ZFI0AiJSRT4SbGHrcms+O0gVlGabJx gJQb0K7rsaHxuEvLz1IYz9hZQm2LTs0ygBVv93qEEupQWic9P7DaR7bUnPBV8pLDh9fO KyWH7cCQKkt2sSaFxY0eu3E0N92FFsneO6r/VaM/5PYh4rxSnLJLv1Rme0Y+TISK/nD4 evmHFQ4JQ0LYkMU5Cas5U1B8g0GwHmrg9GZFHZ2cODrbCljRDk84GzQYQmqAsEB0sv8x vm6e/vxXQ2uGk53XEDGmEQ9Em4AEnBzlx9ypff5OydKqNh9mSP1TD9tOGrEYgzlrYCFl lHQQ== X-Gm-Message-State: AOAM5307v2hw7OK/2dIvpFanvi0WfhAfFqQePe8PKGOiA41G+qEMufJd aQjO3yka9cvZF/MvtzuIUNZ2Jg== X-Google-Smtp-Source: ABdhPJzKpXrgUntAlAYZkvnH4zfUSRM5PQ4E+Cc2yBNkZba/USPxqi82SB3TMQkqjHPHvGE7GCEhtg== X-Received: by 2002:a05:6402:26d0:b0:419:75eb:b3a with SMTP id x16-20020a05640226d000b0041975eb0b3amr13084176edd.0.1649317731392; Thu, 07 Apr 2022 00:48:51 -0700 (PDT) Received: from [192.168.0.185] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id n25-20020aa7db59000000b00415965e9727sm8747258edt.18.2022.04.07.00.48.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 00:48:50 -0700 (PDT) Message-ID: <8d0d8b27-35ff-3693-cf80-897b80c26b4e@linaro.org> Date: Thu, 7 Apr 2022 09:48:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: partitions: Add binding for Sercomm parser Content-Language: en-US To: Mikhail Zhilkin , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski Cc: NOGUCHI Hiroshi , Karim , M , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220406195557.1956-1-csharper2005@gmail.com> <20220406195946.2019-1-csharper2005@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220406195946.2019-1-csharper2005@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/04/2022 21:59, Mikhail Zhilkin wrote: > Add YAML binding for Sercomm partition parser. > > Signed-off-by: Mikhail Zhilkin > --- > .../mtd/partitions/sercomm,sc-partitions.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/sercomm,sc-partitions.yaml > (...) > + > +properties: > + compatible: > + const: sercomm,sc-partitions > + > + scpart-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Partition id in Sercomm partition map Do you really need it? The reg should define the order, unless you expect some incomplete partition list? In any case this requires vendor prefix. > + > +required: > + - compatible Missing reg. > + - scpart-id > + > +additionalProperties: false Are you sure that you tested your bindings? You miss here address/size cells and children, so you should have big fat warning. Plus your DTS example has error and does not compile... Best regards, Krzysztof