From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] Introduce "non-pixel" sub node within iris video node
Date: Wed, 2 Jul 2025 13:05:56 +0200 [thread overview]
Message-ID: <8d243f98-76a8-4126-8f08-651f9d19f6af@kernel.org> (raw)
In-Reply-To: <306223e7-b760-4d37-b5d2-ac04e3c98842@linaro.org>
On 27/06/2025 18:30, Bryan O'Donoghue wrote:
> On 27/06/2025 16:48, Vikash Garodia wrote:
>> Changes in v3:
>> - Add info about change in iommus binding (Thanks Krzysztof)
>> - Link to v2:https://lore.kernel.org/r/20250627-video_cb-v2-0-3931c3f49361@quicinc.com
>
> Hmm.
>
> I would be nice to see what also _wasn't_ done i.e. why you didn't do
> what Dmitry was suggesting, IMO that's as important as stating what you
> did change.
>
> Not a huge deal you explained in a response email your logic already but
It is a deal. Not doing what reviewers are asking is not the standard
practice.
> just as suggestion for future, I think its good practice to go through
> each point and say what you did do, what you didn't do, perhaps what you
> tried and then decided to do in a different way.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-02 11:06 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 15:48 [PATCH v3 0/5] Introduce "non-pixel" sub node within iris video node Vikash Garodia
2025-06-27 15:48 ` [PATCH v3 1/5] media: dt-bindings: add non-pixel property in iris schema Vikash Garodia
2025-06-27 16:31 ` Bryan O'Donoghue
2025-06-27 17:16 ` Vikash Garodia
2025-06-30 15:48 ` neil.armstrong
2025-06-30 15:56 ` Neil Armstrong
2025-07-02 11:13 ` Krzysztof Kozlowski
2025-07-02 11:32 ` Vikash Garodia
2025-07-02 11:46 ` Krzysztof Kozlowski
2025-07-02 13:11 ` Konrad Dybcio
2025-07-02 13:59 ` Krzysztof Kozlowski
2025-07-02 16:36 ` Vikash Garodia
2025-07-02 20:16 ` Krzysztof Kozlowski
2025-07-03 10:11 ` Konrad Dybcio
2025-07-03 7:29 ` Krzysztof Kozlowski
2025-07-02 11:23 ` Krzysztof Kozlowski
2025-07-02 11:45 ` Vikash Garodia
2025-07-02 11:47 ` Krzysztof Kozlowski
2025-07-02 11:55 ` Vikash Garodia
2025-07-02 11:58 ` Krzysztof Kozlowski
2025-07-02 12:08 ` Vikash Garodia
2025-07-02 12:11 ` Krzysztof Kozlowski
2025-06-27 15:48 ` [PATCH v3 2/5] media: iris: register and configure non-pixel node as platform device Vikash Garodia
2025-06-27 17:01 ` Bryan O'Donoghue
2025-07-02 11:04 ` Krzysztof Kozlowski
2025-07-02 11:39 ` Vikash Garodia
2025-07-02 12:45 ` Konrad Dybcio
2025-06-27 15:48 ` [PATCH v3 3/5] media: iris: use np_dev as preferred DMA device in HFI queue management Vikash Garodia
2025-06-27 17:03 ` Bryan O'Donoghue
2025-06-27 15:48 ` [PATCH v3 4/5] media: iris: select appropriate DMA device for internal buffers Vikash Garodia
2025-06-27 17:07 ` Bryan O'Donoghue
2025-06-27 15:48 ` [PATCH v3 5/5] media: iris: configure DMA device for vb2 queue on OUTPUT plane Vikash Garodia
2025-06-27 17:08 ` Bryan O'Donoghue
2025-06-30 7:58 ` Vikash Garodia
2025-07-01 12:04 ` Konrad Dybcio
2025-06-27 16:30 ` [PATCH v3 0/5] Introduce "non-pixel" sub node within iris video node Bryan O'Donoghue
2025-06-27 17:00 ` Vikash Garodia
2025-07-02 11:05 ` Krzysztof Kozlowski [this message]
2025-06-30 15:55 ` neil.armstrong
2025-06-30 18:04 ` neil.armstrong
2025-07-01 8:42 ` Konrad Dybcio
2025-07-01 10:23 ` Vikash Garodia
2025-07-01 13:19 ` Neil Armstrong
2025-07-01 16:11 ` Vikash Garodia
2025-07-02 7:59 ` Neil Armstrong
2025-07-02 11:06 ` Krzysztof Kozlowski
2025-07-02 11:18 ` Krzysztof Kozlowski
2025-07-02 11:37 ` Vikash Garodia
2025-07-02 11:52 ` Krzysztof Kozlowski
2025-07-02 11:54 ` Krzysztof Kozlowski
2025-07-02 12:01 ` Vikash Garodia
2025-07-02 12:05 ` Krzysztof Kozlowski
2025-07-02 12:57 ` Vikash Garodia
2025-07-02 12:06 ` Bryan O'Donoghue
2025-07-02 22:26 ` Dmitry Baryshkov
2025-07-03 7:27 ` Krzysztof Kozlowski
2025-07-03 12:38 ` Konrad Dybcio
2025-07-03 12:54 ` Krzysztof Kozlowski
2025-07-03 15:28 ` Konrad Dybcio
2025-07-03 20:28 ` Bryan O'Donoghue
2025-07-03 21:23 ` Dmitry Baryshkov
2025-07-04 8:23 ` Bryan O'Donoghue
2025-07-04 10:28 ` Konrad Dybcio
2025-07-04 16:45 ` Dmitry Baryshkov
2025-07-04 22:44 ` Bryan O'Donoghue
2025-07-10 18:18 ` Prakash Gupta
2025-07-15 12:15 ` Konrad Dybcio
2025-07-04 19:15 ` Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d243f98-76a8-4126-8f08-651f9d19f6af@kernel.org \
--to=krzk@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).