From: Neil Armstrong <neil.armstrong@linaro.org>
To: Luca Weiss <luca@z3ntu.xyz>, linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: pm8941: fix iadc node
Date: Mon, 26 Sep 2022 10:45:58 +0200 [thread overview]
Message-ID: <8d2d111d-aaa8-5fd9-784f-4c830f2b0a27@linaro.org> (raw)
In-Reply-To: <20220925161821.78030-2-luca@z3ntu.xyz>
On 25/09/2022 18:18, Luca Weiss wrote:
> The iadc node name is supposed to be just 'adc' and the compatible is
> only supposed to be qcom,spmi-iadc according to the bindings.
>
> Adjust the node to match that.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index 3c15eecf2f21..33517cccee01 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -131,8 +131,8 @@ adc-chan@48 {
> };
> };
>
> - pm8941_iadc: iadc@3600 {
> - compatible = "qcom,pm8941-iadc", "qcom,spmi-iadc";
> + pm8941_iadc: adc@3600 {
> + compatible = "qcom,spmi-iadc";
> reg = <0x3600>;
> interrupts = <0x0 0x36 0x0 IRQ_TYPE_EDGE_RISING>;
> qcom,external-resistor-micro-ohms = <10000>;
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2022-09-26 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 16:18 [PATCH 1/2] ARM: dts: qcom: pm8941: fix vadc channel node names Luca Weiss
2022-09-25 16:18 ` [PATCH 2/2] ARM: dts: qcom: pm8941: fix iadc node Luca Weiss
2022-09-26 8:45 ` Neil Armstrong [this message]
2022-09-26 8:54 ` Krzysztof Kozlowski
2022-09-26 15:05 ` Luca Weiss
2022-09-28 7:26 ` Krzysztof Kozlowski
2022-09-27 12:43 ` Konrad Dybcio
2022-09-26 8:44 ` [PATCH 1/2] ARM: dts: qcom: pm8941: fix vadc channel node names Neil Armstrong
2022-09-26 8:54 ` Krzysztof Kozlowski
2022-09-27 13:03 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d2d111d-aaa8-5fd9-784f-4c830f2b0a27@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).