* [PATCH] arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode
@ 2023-10-10 10:46 Caleb Connolly
2023-10-10 11:59 ` Bryan O'Donoghue
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Caleb Connolly @ 2023-10-10 10:46 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Vladimir Zapolskiy, linux-arm-msm, devicetree, Caleb Connolly
The rb2 only has a single USB controller, it can be switched between a
type-c port and an internal USB hub via a DIP switch. Until dynamic
role switching is available it's preferable to put the USB controller
in host mode so that the type-A ports and ethernet are available.
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
base-commit: 6465e260f48790807eef06b583b38ca9789b6072
// Caleb (they/them)
---
arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
index a7278a9472ed..9738c0dacd58 100644
--- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
+++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
@@ -518,7 +518,6 @@ &usb {
&usb_dwc3 {
maximum-speed = "super-speed";
- dr_mode = "peripheral";
};
&usb_hsphy {
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode
2023-10-10 10:46 [PATCH] arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode Caleb Connolly
@ 2023-10-10 11:59 ` Bryan O'Donoghue
2023-10-10 12:05 ` Konrad Dybcio
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2023-10-10 11:59 UTC (permalink / raw)
To: Caleb Connolly, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Vladimir Zapolskiy, linux-arm-msm, devicetree
On 10/10/2023 11:46, Caleb Connolly wrote:
> The rb2 only has a single USB controller, it can be switched between a
> type-c port and an internal USB hub via a DIP switch. Until dynamic
> role switching is available it's preferable to put the USB controller
> in host mode so that the type-A ports and ethernet are available.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
>
> // Caleb (they/them)
> ---
> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index a7278a9472ed..9738c0dacd58 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -518,7 +518,6 @@ &usb {
>
> &usb_dwc3 {
> maximum-speed = "super-speed";
> - dr_mode = "peripheral";
> };
>
> &usb_hsphy {
>
No fixes tag ?
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode
2023-10-10 10:46 [PATCH] arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode Caleb Connolly
2023-10-10 11:59 ` Bryan O'Donoghue
@ 2023-10-10 12:05 ` Konrad Dybcio
2023-10-10 16:23 ` Vladimir Zapolskiy
2023-10-16 18:59 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2023-10-10 12:05 UTC (permalink / raw)
To: Caleb Connolly, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Vladimir Zapolskiy, linux-arm-msm, devicetree
On 10/10/23 12:46, Caleb Connolly wrote:
> The rb2 only has a single USB controller, it can be switched between a
> type-c port and an internal USB hub via a DIP switch. Until dynamic
> role switching is available it's preferable to put the USB controller
> in host mode so that the type-A ports and ethernet are available.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
Fixes: eaa53a85748d ("arm64: dts: qcom: qrb4210-rb2: Enable USB node")
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode
2023-10-10 10:46 [PATCH] arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode Caleb Connolly
2023-10-10 11:59 ` Bryan O'Donoghue
2023-10-10 12:05 ` Konrad Dybcio
@ 2023-10-10 16:23 ` Vladimir Zapolskiy
2023-10-16 18:59 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Vladimir Zapolskiy @ 2023-10-10 16:23 UTC (permalink / raw)
To: Caleb Connolly, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree
On 10/10/23 13:46, Caleb Connolly wrote:
> The rb2 only has a single USB controller, it can be switched between a
> type-c port and an internal USB hub via a DIP switch. Until dynamic
> role switching is available it's preferable to put the USB controller
> in host mode so that the type-A ports and ethernet are available.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
>
> // Caleb (they/them)
> ---
> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index a7278a9472ed..9738c0dacd58 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -518,7 +518,6 @@ &usb {
>
> &usb_dwc3 {
> maximum-speed = "super-speed";
> - dr_mode = "peripheral";
> };
>
> &usb_hsphy {
>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Thank you for the fix!
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode
2023-10-10 10:46 [PATCH] arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode Caleb Connolly
` (2 preceding siblings ...)
2023-10-10 16:23 ` Vladimir Zapolskiy
@ 2023-10-16 18:59 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2023-10-16 18:59 UTC (permalink / raw)
To: Caleb Connolly
Cc: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Vladimir Zapolskiy, linux-arm-msm, devicetree
On Tue, Oct 10, 2023 at 11:46:58AM +0100, Caleb Connolly wrote:
> The rb2 only has a single USB controller, it can be switched between a
> type-c port and an internal USB hub via a DIP switch. Until dynamic
> role switching is available it's preferable to put the USB controller
> in host mode so that the type-A ports and ethernet are available.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Applied, thanks.
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
>
> // Caleb (they/them)
> ---
> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index a7278a9472ed..9738c0dacd58 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -518,7 +518,6 @@ &usb {
>
> &usb_dwc3 {
> maximum-speed = "super-speed";
> - dr_mode = "peripheral";
> };
>
> &usb_hsphy {
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-16 18:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-10 10:46 [PATCH] arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode Caleb Connolly
2023-10-10 11:59 ` Bryan O'Donoghue
2023-10-10 12:05 ` Konrad Dybcio
2023-10-10 16:23 ` Vladimir Zapolskiy
2023-10-16 18:59 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).