From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF67C43334 for ; Tue, 5 Jul 2022 17:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232788AbiGER4g (ORCPT ); Tue, 5 Jul 2022 13:56:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230043AbiGER4e (ORCPT ); Tue, 5 Jul 2022 13:56:34 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 679C51B794 for ; Tue, 5 Jul 2022 10:56:33 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id j21so21922145lfe.1 for ; Tue, 05 Jul 2022 10:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=shYinKXG4MQdFX7ZW9KlW+0lvbviw1UaiNViTCYpf9g=; b=lu9+iYAES8x+XD//Jw2ejvInxe149YmabvcbqQQYccKT2ogYWV1q/8A/jBENzR68W2 PiWgfT9r65LMRPFo+EfVjwi0H9bsIsViE33osoC5KekrSl1EeChAer8Q1AAGy3ozZ+Qw FA0CS10uZrfvG46CvCgrNxSzGSxGO34BQSK4/oKsVCOt/4hf/8EjNpT32bVzOA5sN+V9 KUTHThTY8qn0pyI7T+cMtkMW6FD+kxWbs0Zk6VKp5P1AoS0tPoEeHNmn0jLLs9h8sHOZ 6TdsQEf2dANyqiQsHQK9UGNivihNibZgCt+lmPn2qb6S8WuhaaGCScHNJqzcwLjgeaUr +pyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=shYinKXG4MQdFX7ZW9KlW+0lvbviw1UaiNViTCYpf9g=; b=Lhz52zABfcKBdF5qdXGIVWEB96g+d7fjzCuyZsIdTA//EI1LZFa3jQknLnpJMRCTUb 2WsQ++Of2i+dbwlTA6uuXfm9Ir7SLZhngjLJuztii1HWEl3QX4+kUvAmzFLEuPMiuaQJ 87d1tY3ohtBXrRspfPMNrn/9LC9KuKXSrkg0M3+cGcK3eRNAMDnemom7NmuPqRszYJAc FDqTrC0HSr9BKbKf+l2tAThkdLHRPVSrBX1i1OI6Uw7c9+nhakqnCZte7JIouMLUw86Z wm5oeYJ5WJHYpWFNFLFoSY1P5d2oqoNRi90qvZuEkvgvh/R5OaCHzNif7xLMFATtezAQ oMZg== X-Gm-Message-State: AJIora9G1xgF59pihtgysiVgis/ixv5mmEHcjgRHZCoLl3dg3HlLDWDK 00VHsIsGl7xtDoa/ABcc+h/FtQ== X-Google-Smtp-Source: AGRyM1uhGiiqD3O6wNSZmHwZAko+jzy78knQzJWQpkSCqA52mH/D7cFAy2+U6XnCp2K/VHXfucRtaw== X-Received: by 2002:a05:6512:2508:b0:480:f1cb:64ad with SMTP id be8-20020a056512250800b00480f1cb64admr25069896lfb.359.1657043790156; Tue, 05 Jul 2022 10:56:30 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id z8-20020a05651c022800b0025d37955bc7sm404247ljn.74.2022.07.05.10.56.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 10:56:29 -0700 (PDT) Message-ID: <8d71000b-e9d7-3586-5421-36a1fb367b5e@linaro.org> Date: Tue, 5 Jul 2022 19:56:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] dt-binding: sound: Convert atmel pdmic to json-schema Content-Language: en-US To: Ryan.Wanner@microchip.com, Claudiu.Beznea@microchip.com, nicolas.ferre@microchip.com, alexandre.berna@microchip.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220705162142.17558-1-Ryan.Wanner@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20220705162142.17558-1-Ryan.Wanner@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/07/2022 18:21, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner > > Convert Atmel PDMIC devicetree binding to json-schema. > Change file naming to match json-schema naming. > > Signed-off-by: Ryan Wanner > --- > .../bindings/sound/atmel,sama5d2-pdmic.yaml | 104 ++++++++++++++++++ > .../devicetree/bindings/sound/atmel-pdmic.txt | 55 --------- You need to send the patches to proper folks with proper subject prefix. Use get_maintainers.pl for the first and `git log --oneline --` for the second. > 2 files changed, 104 insertions(+), 55 deletions(-) > create mode 100644 Documentation/devicetree/bindings/sound/atmel,sama5d2-pdmic.yaml > delete mode 100644 Documentation/devicetree/bindings/sound/atmel-pdmic.txt > > diff --git a/Documentation/devicetree/bindings/sound/atmel,sama5d2-pdmic.yaml b/Documentation/devicetree/bindings/sound/atmel,sama5d2-pdmic.yaml > new file mode 100644 > index 000000000000..cb34c0fc4fc8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/atmel,sama5d2-pdmic.yaml > @@ -0,0 +1,104 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/atmel,sama5d2-pdmic.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel PDMIC driver under ALSA SoC architecture "driver" and ALSA are Linux specific, so this could be corrected during conversion to name the hardware. > + > +maintainers: > + - Claudiu Beznea > + > +description: > + Atmel Pulse Density Modulation Interface Controller > + (PDMIC) peripheral is a mono PDM decoder module > + that decodes an incoming PDM sample stream. > + > +properties: > + compatible: > + items: One item, so no need for items. > + - const: atmel,sama5d2-pdmic > + > + reg: > + description: Should contain PDMIC registers location and length. Skip description, it's obvious. > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + description: > + Must contain an entry for each required entry in clock-names. > + Please refer to clock-bindings.txt. Skip description. > + > + items: > + - description: peripheral clock. > + - description: generated clock. Skip trailing dots, since you do not start with capital letter. > + > + clock-names: > + items: > + - const: pclk > + - const: gclk > + > + dmas: > + maxItems: 1 > + > + dma-names: > + const: rx > + > + atmel,mic-min-freq: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The minimal frequency that the microphone supports. > + > + atmel,mic-max-freq: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The maximal frequency that the microphone supports. > + > + atmel,model: > + description: The user-visible name of this sound card. > + $ref: /schemas/types.yaml#/definitions/string > + default: PDMIC > + > + atmel,mic-offset: > + $ref: /schemas/types.yaml#/definitions/int32 > + description: The offset that should be added. > + default: 0 > + > +required: > + - compatible > + - reg > + - interrupts > + - dmas > + - dma-names > + - clock-names > + - clocks > + - atmel,mic-min-freq > + - atmel,mic-max-freq > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + pdmic: sound@f8018000 { > + compatible = "atmel,sama5d2-pdmic"; Use four space for DTS indentation. > + reg = <0xf8018000 0x124>; > + interrupts = <48 IRQ_TYPE_LEVEL_HIGH 7>; > + dmas = <&dma0 Best regards, Krzysztof