From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD66C43219 for ; Thu, 17 Nov 2022 15:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234786AbiKQPtq (ORCPT ); Thu, 17 Nov 2022 10:49:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234053AbiKQPtp (ORCPT ); Thu, 17 Nov 2022 10:49:45 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A02C7019A; Thu, 17 Nov 2022 07:49:41 -0800 (PST) Received: from [192.168.1.15] (91-154-32-225.elisa-laajakaista.fi [91.154.32.225]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BD412929; Thu, 17 Nov 2022 16:49:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668700179; bh=dCq7BZPM04IF4OeB3g2d9it3HFFw4GKBrkhYKw2JoRo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IB5dcSr96oKd9sKI0F7g5DLossoqeaf9tf9nTzk42f/d5Eb+BTxPEwRI99NIjQCtZ U5SdPo1Z2NG3RYLGpF9KcwnvNf9RYaWt4K5x7qTXmEj2kN1ge4QtUrO/gqes5oQG6r 0x5PKybo+JmpOk1c9P8gqBYWSqFcUl8hM/M+NtRY= Message-ID: <8d848493-24a8-4ffb-239e-9e7baa232a42@ideasonboard.com> Date: Thu, 17 Nov 2022 17:49:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1 7/8] drm: rcar-du: dsi: Add r8A779g0 support Content-Language: en-US To: Kieran Bingham , Geert Uytterhoeven , Krzysztof Kozlowski , Laurent Pinchart , Magnus Damm , Rob Herring , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Tomi Valkeinen References: <20221117122547.809644-1-tomi.valkeinen@ideasonboard.com> <20221117122547.809644-8-tomi.valkeinen@ideasonboard.com> <166869996543.50677.17182739414507530884@Monstersaurus> From: Tomi Valkeinen In-Reply-To: <166869996543.50677.17182739414507530884@Monstersaurus> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/11/2022 17:46, Kieran Bingham wrote: >> + if (ret) >> + return ret; >> + >> + if (setup_info->hsfreq <= MHZ(1000)) >> + ret = WRITE_PHTW(0x01020100, 0x01910170, 0x01020171, >> + 0x01110172); > The <=1Gbps reads: > > <=1Gbps > > Set PHTW=H’01020100 > Set PHTW=H’01010172 > Set PHTW=H’01570170 > Set PHTW=H’01060171 > Set PHTW=H’01110172 > > Is it clear why theres a difference here? What doc is that? Mine (R19UH0172EJ0054 Rev.0.54) says: Set PHTW=H’01020100 Set PHTW=H’01910170 Set PHTW=H’01020171 Set PHTW=H’01110172 Tomi