From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Leo Li <leoyang.li@nxp.com>, Michael Walle <michael@walle.cc>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Shawn Guo <shawnguo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] dt-bindings: interrupt-controller: fsl,ls-extirq: convert to YAML
Date: Thu, 28 Apr 2022 08:16:19 +0200 [thread overview]
Message-ID: <8d9130b5-7459-bb26-79c7-3d83f7dd29a0@linaro.org> (raw)
In-Reply-To: <AS8PR04MB89464877E53B7F7B14A814178FFA9@AS8PR04MB8946.eurprd04.prod.outlook.com>
On 27/04/2022 22:08, Leo Li wrote:
>> Convert the fsl,ls-extirq binding to the new YAML format.
>>
>> In contrast to the original binding documentation, there are three
>> compatibles which are used in their corresponding device trees which have a
>> specific compatible and the (already documented) fallback
>> compatible:
>> - "fsl,ls1046a-extirq", "fsl,ls1043a-extirq"
>> - "fsl,ls2080a-extirq", "fsl,ls1088a-extirq"
>> - "fsl,lx2160a-extirq", "fsl,ls1088a-extirq"
>>
>> Depending on the number of the number of the external IRQs which is
>> usually 12 except for the LS1021A where there are only 6, the interrupt-map-
>> mask was reduced from 0xffffffff to 0xf and 0x7 respectively and the number
>> of interrupt-map entries have to match.
>
> I assume this change won't prevent driver to be compatible with older device trees using the 0xffffffff? The original 0xffffffff should work for both 6/12 interrupts or whatever reasonable number of interrupts that maybe used in future SoCs. So the purpose of this change is to make the binding more specific to catch more errors in device tree?
Yes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-28 6:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 7:53 [PATCH v3 0/4] dt-bindings: convert freescale extirq and scfg schemas Michael Walle
2022-04-27 7:53 ` [PATCH v3 1/4] ARM: dts: ls1021a: reduce the interrupt-map-mask Michael Walle
2022-05-05 3:56 ` Shawn Guo
2022-04-27 7:53 ` [PATCH v3 2/4] arm64: dts: freescale: reduce the interrup-map-mask Michael Walle
2022-05-05 3:56 ` Shawn Guo
2022-04-27 7:53 ` [PATCH v3 3/4] dt-bindings: interrupt-controller: fsl,ls-extirq: convert to YAML Michael Walle
2022-04-27 20:08 ` Leo Li
2022-04-28 6:16 ` Krzysztof Kozlowski [this message]
2022-04-28 7:10 ` Krzysztof Kozlowski
2022-04-28 22:46 ` Rob Herring
2022-04-27 7:53 ` [PATCH v3 4/4] dt-bindings: fsl: convert fsl,layerscape-scfg " Michael Walle
2022-04-27 14:18 ` Rob Herring
2022-04-28 22:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d9130b5-7459-bb26-79c7-3d83f7dd29a0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maz@kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).