From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2858EC433EF for ; Thu, 28 Apr 2022 09:45:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbiD1Jsb (ORCPT ); Thu, 28 Apr 2022 05:48:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346711AbiD1J0p (ORCPT ); Thu, 28 Apr 2022 05:26:45 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0AF37B553 for ; Thu, 28 Apr 2022 02:23:29 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id d6so4787568ede.8 for ; Thu, 28 Apr 2022 02:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=jB9oC3xjpoFxUS9LFdQlfVxwFGaXRBq5QGeiE+tRIqM=; b=nwxJLpJvy+wRjL/DDaJ/04bHNsQKwmjHqfcQlgcfGg7zgRkGsl425sj0PSAkzSP1TT C649QghEbY76G7BX+E0MRj4p9vlpn0jgvkYBfx5YyWJjNndEb5EiXl3T6C6vex6rSWoQ l0w2z18kT2npM8rjj6JSz/HVAUY68Of+WRZswANlJOuaWLFIIg+3Sgw4Y4uZft3p3Cw0 pcI4xRrsw/bn8Y3pLl5hq7/TC0nwv3o6fOCx1gEMMHVhiXRENcCxYkJPyuwi5y0sD0mf DuFHmMNI58YCgdoRqQ72JwIzRu7T8+yoyv0kHDPOKuNKjKB3efxoPbVYkBlu8Jyk6ejt TZzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=jB9oC3xjpoFxUS9LFdQlfVxwFGaXRBq5QGeiE+tRIqM=; b=F9oLlJPrHbNtmj3pYPE36jElqax30loCuPSEf7FmQ16CqIEnqdK5VqWLpKHsct40WU CLI3MS83jTXrrX4+KEi3AaEV4xlyMwnP0k6xNqHWy1rJIgOomF8j9FzR9xZR3ZZ4eZIB fWRjlrBNaxrXKHcBzTR2SlRSsElb2HHNtgmSPy6yzp09/5850JQoKOLdBLy19b6wqE08 xBlq3zJ45q/517loYojhg2spxip3hy+JVYWcyPJHBHKzJL1lKL+x6Z6gIWCTuVLLlFLZ 3SuoYtx5/9ysGuS8h0whojOyquxyJzBzC6KrbzX2z0eWfrhzBmbtMYofLDcJry2Apb3V noiw== X-Gm-Message-State: AOAM533mdTZqaGH7PI9CE1V1yjsllA4IuWQ8tHfGUuzLsL1oAdhZSzRE aq3U3iKfcjtNIF6k5qkJnau7Kg== X-Google-Smtp-Source: ABdhPJxqQB4FhB1qwQB/ovi3BQShEh8+1kJBd2RzhXx0hDKyJJUUMioSgGqZTIvWf08I0UyrdgaiKQ== X-Received: by 2002:a05:6402:3584:b0:423:e4d0:34f with SMTP id y4-20020a056402358400b00423e4d0034fmr34874477edc.72.1651137808445; Thu, 28 Apr 2022 02:23:28 -0700 (PDT) Received: from [192.168.0.161] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id ew15-20020a170907950f00b006f3a3d60b9csm4725483ejc.63.2022.04.28.02.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 02:23:27 -0700 (PDT) Message-ID: <8d919dc0-80a2-106f-9397-49263cf4ed5a@linaro.org> Date: Thu, 28 Apr 2022 11:23:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 4/7] dt-bindings: clock: Add Nuvoton WPCM450 clock/reset controller Content-Language: en-US To: =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Joel Stanley Cc: Krzysztof Kozlowski , linux-clk@vger.kernel.org, OpenBMC Maillist , Linux Kernel Mailing List , LINUXWATCHDOG , devicetree , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Daniel Lezcano , Thomas Gleixner , Philipp Zabel , Wim Van Sebroeck , Guenter Roeck References: <20220422183012.444674-1-j.neuschaefer@gmx.net> <20220422183012.444674-5-j.neuschaefer@gmx.net> <31cb9af1-173d-bef5-64da-ccf5a01f2485@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/04/2022 10:55, Jonathan Neuschäfer wrote: >>> >>> All these defines should be in second header in dt-bindings/reset/... >> >> I disagree. It makes more sense to keep the definitions together, and >> it's all for the same hardware and driver. These are bindings so the usage by same driver (Linux implementation) matters less or even does not matter. Driver can be split from one to several and you would need to include clocks in your just-split-reset driver. Such driver split should not affect bindings, therefore having the binding headers separate is actually the most flexible. > > It's for the same hardware, DT node, and driver. > > I could imagine splitting it into > > include/dt-bindings/clock/nuvoton,wpcm450-clk.h and > include/dt-bindings/reset/nuvoton,wpcm450-clk.h > > if someone insists on it. > > For convenience (being able to see all relevant definitions for > nuvoton,wpcm450-clk at once), I'd prefer to keep the definitions together. I don't insist. For some of the devices we split it, for some not. Best regards, Krzysztof