From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 957A63644CA; Mon, 10 Aug 2026 06:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786343532; cv=none; b=ekpSo659CIoKSEKuWOXzRamVvAdiKhdnjili9sQp8JViceDq4TTSARs46LC+fofK6dAOGAgy+8MA1+KLzfLJcw6MxWDk/HEYCa5r0qJoQXIEJUfx6jwhPEECn2UJ9gANARS2MhvT9PdHr7dxnVB4dFB/pmGld89kkVarKGLlgxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786343532; c=relaxed/simple; bh=5TmcLvq5kwnCAZWLdEZJKeXFr3bcxiys5cTX46fLtvQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VoV6cajiR6Ow8zMSqRK1WLrWFCbnHgTFTTDJBd4l9okTtgVoBEESh3XscZVN9QSztZJj4JhUSozSB/exl3x8LaAWtvx2wgMVHxwyjK1pdqSpXkZjOVxBAop68Ah0tUZrCQHViuRaS9tO3fu8nG5MaaSBuqFzOC1rxI2r1UsFePo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mkLuhHX7; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mkLuhHX7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F9411F000E9; Mon, 10 Aug 2026 06:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786343531; bh=wSS8AMze12K8iYUpSLQ8N+VPReKhCV7W3aisDuH/XNE=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=mkLuhHX79ou9XHJbxTJ98kdoT8fDDdVnRuroQdgmSosn/5uc2X/qwWSTmFdiu8xsB 26M/ABbjiyWFJRBA6WZxbjRIvNIEcuaiPve1bpOhgD9v6G/8CisfTGFn5lqBHcV6vN nZt+bCbxIf1oRidhGmXvruzw7GV8V2JH78zx3ZNWpXRD12zmpOhk4PabMKVzUt2PoA GpaUqrqiNFsWawQq91RNST7ukaBdoYx16z/HeHWPyKjE0qq+cE9PgI3qQM77NFU4Ih q+EwKPMz7oU4Srpl18wlJoJguSaSN1qnc6iKPE/LZuOnX5PqW0v8IpB/+79MuffqA1 HV8jCCmKv93wQ== Message-ID: <8d924236-5a1f-4cd6-a7a6-d12b1bed5615@kernel.org> Date: Mon, 10 Aug 2026 08:31:56 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 08/14] dt-bindings: media: mediatek: vcodec: add decoder dt-bindings for mt8196 To: =?UTF-8?B?S3lyaWUgV3UgKOWQtOaZlyk=?= Cc: "fshao@chromium.org" , =?UTF-8?B?WXVuZmVpIERvbmcgKOiRo+S6kemjnik=?= , "conor+dt@kernel.org" , "fanwu01@zju.edu.cn" , "jacopo.mondi@ideasonboard.com" , "haoxiang_li2024@163.com" , "rongqianfeng@vivo.com" , AngeloGioacchino Del Regno , =?UTF-8?B?QW5kcmV3LUNUIENoZW4gKOmZs+aZuui/qik=?= , "linux-media@vger.kernel.org" , "ribalda@chromium.org" , "wenst@chromium.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kees@kernel.org" , "benjamin.gaignard@collabora.com" , =?UTF-8?B?SXJ1aSBXYW5nICjnjovnkZ4p?= , "krzk+dt@kernel.org" , "linux-mediatek@lists.infradead.org" , "p.zabel@pengutronix.de" , =?UTF-8?B?VGlmZmFueSBMaW4gKOael+aFp+ePiik=?= , "sakari.ailus@linux.intel.com" , "matthias.bgg@gmail.com" , "tfiga@chromium.org" , "mchehab@kernel.org" , "sebastian.fricke@collabora.com" , "robh@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "nicolas.dufresne@collabora.com" , "laurent.pinchart+renesas@ideasonboard.com" , "hverkuil+cisco@kernel.org" References: <20260720012056.1026551-1-kyrie.wu@mediatek.com> <20260720012056.1026551-9-kyrie.wu@mediatek.com> <20260720-gregarious-satisfied-shrew-f71cba@quoll> <8558035b-d825-4e56-bfd2-551cff51f73f@kernel.org> <2b567b39434d7d125dcdca75e198a1442e4c2f22.camel@mediatek.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <2b567b39434d7d125dcdca75e198a1442e4c2f22.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/08/2026 05:09, Kyrie Wu (吴晗) wrote: > On Mon, 2026-07-20 at 12:19 +0200, Krzysztof Kozlowski wrote: >> On 20/07/2026 08:26, Kyrie Wu (吴晗) wrote: >>> On Mon, 2026-07-20 at 07:49 +0200, Krzysztof Kozlowski wrote: >>>> On 20/07/2026 07:46, Krzysztof Kozlowski wrote: >>>>> On Mon, Jul 20, 2026 at 09:20:50AM +0800, Kyrie Wu wrote: >>>>>> Add the MT8196 compatible string to the MediaTek vcodec >>>>>> subdev >>>>>> decoder binding. >>>>>> >>>>>> Compared to previous ICs, the MT8196 supports a 10-bit >>>>>> decoder >>>>>> and has a decoding capability of 4K@120fps. It also supports >>>>>> 36-bit DRAM IOVA address and Video Power Control to optimize >>>>>> bandwidth and voltage usage. >>>>> >>>>> Please wrap commit message according to Linux coding style / >>>>> submission >>>>> process (neither too early nor over the limit): >>>>> https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst*L597__;Iw!!CTRNKA9wMg0ARbw!gDjbq0EZNkhLTzuJM_w5PopnDFej1mG4qnkRFgyoiU7Dvhm7tj3MeG5eZYNGA0L0G_61j-cmdIxORA$ >>>>>   >>>>> >>>>>> >>>>>> Signed-off-by: Kyrie Wu >>>>>> Acked-by: Nicolas Dufresne >>>>>> --- >>>>>>  .../bindings/media/mediatek,vcodec-subdev- >>>>>> decoder.yaml           >>>>>>> 1 + >>>>>>  1 file changed, 1 insertion(+) >>>>> >>>>> Acked-by: Krzysztof Kozlowski >>>>> >>>> >>>> Actually no. I checked previous comments and you received >>>> feedback >>>> which >>>> you basically ignored, so explain why this model has flexible >>>> number >>>> of >>>> clocks >>>> >>>> Best regards, >>>> Krzysztof >>> >>> Dear Krzysztof, >>> >>> As mentioned in the previous version of the communication, the >>> information regarding clk was incorrect, and I have corrected it in >>> this version.  >>> >>> Thank you for your attention and reminder. >> >> Read my message carefully instead of responding whatever necessary to >> make me go away. >> >> NAK >> >> Where did you explain that device has flexible number of clocks? >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > > You are right, my previous reply was not sufficient. Sorry about that. > > MT8196 has a fixed set of clock inputs: 9 clocks for the decoder > hardware > and 3 clocks for the VCP interface. By "flexible number of clocks", > I meant that clock control can be split between the kernel driver > and VCP firmware. This is a software implementation detail, > not a hardware or DT binding property. My wording was incorrect. > > The binding should not imply that the number of clocks is flexible. > I have updated the commit message to clarify this. SW detail so not relevant to the bindings? Then my NAK stays. Drop my tag and fix the patch. If you do not intend to fix the patch - I really could not get from above whether you agree with previous feedback or not - then this should not be applied. Best regards, Krzysztof