From: Krzysztof Kozlowski <krzk@kernel.org>
To: FUKAUMI Naoki <naoki@radxa.com>, heiko@sntech.de
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: add dts for Radxa ROCK Pi E v3.0
Date: Sun, 23 Jun 2024 10:07:19 +0200 [thread overview]
Message-ID: <8da8e56a-e24f-4b56-9861-df55369c984f@kernel.org> (raw)
In-Reply-To: <20240623075318.80492-1-naoki@radxa.com>
On 23/06/2024 09:53, FUKAUMI Naoki wrote:
> Radxa ROCK Pi E v3.0 has DDR4 SDRAM instead of DDR3 SDRAM.
>
> for Linux, this change doesn't make any difference from a device tree
> POV. but, for bootloader (U-Boot TPL), it makes a difference.
What difference?
>
> bootloader needs a separeted dts for v3, so I add new dts for it.
> dtb can be shared between v3 and prior, so I don't touch Makefile.
I don't understand. If you have the same DTB then you do not need second
DTS.
This change really lacks proper explanation or is just unnecessary. If
change is proven as necessary, then you also miss compatible and model.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-23 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 7:53 [PATCH] arm64: dts: rockchip: add dts for Radxa ROCK Pi E v3.0 FUKAUMI Naoki
2024-06-23 8:07 ` Krzysztof Kozlowski [this message]
2024-06-23 8:18 ` FUKAUMI Naoki
2024-06-23 10:43 ` Heiko Stübner
2024-06-23 11:59 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8da8e56a-e24f-4b56-9861-df55369c984f@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).