From: Krzysztof Kozlowski <krzk@kernel.org>
To: Joel Stanley <joel@jms.id.au>, "Rob Herring (Arm)" <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: dts: aspeed: Use standard 'i2c' bus node name
Date: Mon, 24 Jun 2024 06:46:57 +0200 [thread overview]
Message-ID: <8dabf3d1-2d23-4adc-a804-2b7aa5fe16e9@kernel.org> (raw)
In-Reply-To: <CACPK8Xes5vp+3YpQ3L5ix=LaDv7oWtqGFVc8moQf4D+o3rnLjg@mail.gmail.com>
On 24/06/2024 03:55, Joel Stanley wrote:
> On Sat, 1 Jun 2024 at 05:01, Rob Herring (Arm) <robh@kernel.org> wrote:
>>
>> The standard node name for I2C buses is 'i2c'.
>
> Unfortunately this can't be merged, as it will break userspace. There
> is a lot of code out there that looks up devices based on the device
> tree node path:
>
> https://github.com/openbmc/phosphor-state-manager/blob/3c1351cc2b63178876ef68f4107c9804d2e17dcc/meson.options#L140
Eh, thanks for sharing.
That's totally stupid user-space. The sysfs path to /sys/devices, or
some grep by compatible, would be fine, but iterating over firmware/DT
is just wrong.
Reminds me USB and ChromeOS. They could fix their userspace, so probably
folks here can as well. I filled a bug.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-24 4:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 19:31 [PATCH] arm: dts: aspeed: Use standard 'i2c' bus node name Rob Herring (Arm)
2024-06-04 1:53 ` Andrew Jeffery
2024-06-07 9:44 ` kernel test robot
2024-06-23 12:21 ` Krzysztof Kozlowski
2024-06-24 1:55 ` Joel Stanley
2024-06-24 4:46 ` Krzysztof Kozlowski [this message]
2024-06-24 16:49 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dabf3d1-2d23-4adc-a804-2b7aa5fe16e9@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).