From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
To: Rob Herring <robh@kernel.org>, jae.hyun.yoo@intel.com
Cc: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
openipmi-developer@lists.sourceforge.net,
linux-aspeed@lists.ozlabs.org,
Haiyue Wang <haiyue.wang@linux.intel.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Cedric Le Goater <clg@kaod.org>, Corey Minyard <minyard@acm.org>,
ChiaWei Wang <chiawei_wang@aspeedtech.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH -next v2 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property
Date: Wed, 3 Nov 2021 09:08:04 -0700 [thread overview]
Message-ID: <8db279c9-4c76-91a5-3617-a17effb2d103@linux.intel.com> (raw)
In-Reply-To: <1635902437.654631.3880388.nullmailer@robh.at.kernel.org>
Hi Rob,
On 11/2/2021 6:20 PM, Rob Herring wrote:
> On Tue, 02 Nov 2021 13:37:16 -0700, jae.hyun.yoo@intel.com wrote:
>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>
>> Add 'clocks' as a required property.
>>
>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>> ---
>> v1 -> v2:
>> Changes sinve v1:
>> - Added 'clocks' property into kcs-bmc bindings using
>> 'aspeed,ast2400-kcs-bmc.yaml' because it's not merged into
>> 'aspeed-lpc.yaml' yet. The bindings merging could be done using a
>> separate patch later.
>>
>> .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1549943
>
>
> kcs@114: 'clocks' is a required property
> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml
>
> kcs@24: 'clocks' is a required property
> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml
>
> kcs@28: 'clocks' is a required property
> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml
>
> kcs@2c: 'clocks' is a required property
> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml
>
#4/6 in this patch adds 'clocks' into aspeed-g5.dtsi and aspeed-g6.dtsi
as a default property and all above dts files include the dtsi file so
these warning shouldn't be seen. Is it a result after applying all
changes in this series or just after cherry picking #5/6 patch only?
I tested 'dtbs_check' before submitting this series I tested it again
and got the same good result like below.
Aren't the above warnings false positive? Or did I miss something?
Thanks,
Jae
$ ARCH=arm make dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
HOSTCC scripts/basic/fixdep
HOSTCC scripts/dtc/dtc.o
HOSTCC scripts/dtc/flattree.o
HOSTCC scripts/dtc/fstree.o
HOSTCC scripts/dtc/data.o
HOSTCC scripts/dtc/livetree.o
HOSTCC scripts/dtc/treesource.o
HOSTCC scripts/dtc/srcpos.o
HOSTCC scripts/dtc/checks.o
HOSTCC scripts/dtc/util.o
LEX scripts/dtc/dtc-lexer.lex.c
YACC scripts/dtc/dtc-parser.tab.[ch]
HOSTCC scripts/dtc/dtc-lexer.lex.o
HOSTCC scripts/dtc/dtc-parser.tab.o
HOSTCC scripts/dtc/yamltree.o
HOSTLD scripts/dtc/dtc
HOSTCC scripts/dtc/libfdt/fdt.o
HOSTCC scripts/dtc/libfdt/fdt_ro.o
HOSTCC scripts/dtc/libfdt/fdt_wip.o
HOSTCC scripts/dtc/libfdt/fdt_sw.o
HOSTCC scripts/dtc/libfdt/fdt_rw.o
HOSTCC scripts/dtc/libfdt/fdt_strerror.o
HOSTCC scripts/dtc/libfdt/fdt_empty_tree.o
HOSTCC scripts/dtc/libfdt/fdt_addresses.o
HOSTCC scripts/dtc/libfdt/fdt_overlay.o
HOSTCC scripts/dtc/fdtoverlay.o
HOSTLD scripts/dtc/fdtoverlay
SCHEMA Documentation/devicetree/bindings/processed-schema.json
DTC arch/arm/boot/dts/aspeed-ast2500-evb.dtb
DTC arch/arm/boot/dts/aspeed-ast2600-evb-a1.dtb
DTC arch/arm/boot/dts/aspeed-ast2600-evb.dtb
DTC arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dtb
DTC arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dtb
DTC arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb
DTC arch/arm/boot/dts/aspeed-bmc-arm-stardragon4800-rep2.dtb
DTC arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dtb
DTC arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-cmm.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-fuji.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-galaxy100.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-minipack.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-wedge400.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-yamp.dtb
DTC arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dtb
DTC arch/arm/boot/dts/aspeed-bmc-ibm-everest.dtb
DTC arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dtb
DTC arch/arm/boot/dts/aspeed-bmc-ibm-rainier-1s4u.dtb
DTC arch/arm/boot/dts/aspeed-bmc-ibm-rainier-4u.dtb
DTC arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dtb
DTC arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dtb
DTC arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dtb
DTC arch/arm/boot/dts/aspeed-bmc-lenovo-hr630.dtb
DTC arch/arm/boot/dts/aspeed-bmc-lenovo-hr855xg2.dtb
DTC arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dtb
DTC arch/arm/boot/dts/aspeed-bmc-opp-lanyang.dtb
DTC arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dtb
DTC arch/arm/boot/dts/aspeed-bmc-opp-mowgli.dtb
DTC arch/arm/boot/dts/aspeed-bmc-opp-nicole.dtb
DTC arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dtb
DTC arch/arm/boot/dts/aspeed-bmc-opp-romulus.dtb
DTC arch/arm/boot/dts/aspeed-bmc-opp-swift.dtb
DTC arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dtb
DTC arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dtb
DTC arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dtb
DTC arch/arm/boot/dts/aspeed-bmc-opp-zaius.dtb
DTC arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dtb
DTC arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dtb
DTC arch/arm/boot/dts/aspeed-bmc-supermicro-x11spi.dtb
DTC arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dtb
DTC arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtb
DTC arch/arm/boot/dts/aspeed-ast2500-evb.dt.yaml
CHECK arch/arm/boot/dts/aspeed-ast2500-evb.dt.yaml
DTC arch/arm/boot/dts/aspeed-ast2600-evb-a1.dt.yaml
CHECK arch/arm/boot/dts/aspeed-ast2600-evb-a1.dt.yaml
DTC arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml
CHECK arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-arm-stardragon4800-rep2.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-arm-stardragon4800-rep2.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-cmm.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-cmm.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-fuji.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-fuji.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-galaxy100.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-galaxy100.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-minipack.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-minipack.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-wedge40.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-wedge100.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-wedge400.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-wedge400.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-yamp.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-yamp.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-ibm-everest.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-ibm-everest.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-ibm-rainier-1s4u.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-ibm-rainier-1s4u.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-ibm-rainier-4u.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-ibm-rainier-4u.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-lenovo-hr630.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-lenovo-hr630.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-lenovo-hr855xg2.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-lenovo-hr855xg2.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-opp-lanyang.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-opp-lanyang.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-opp-mowgli.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-opp-mowgli.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-opp-nicole.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-opp-nicole.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-opp-romulus.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-opp-romulus.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-opp-swift.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-opp-swift.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-opp-zaius.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-opp-zaius.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-supermicro-x11spi.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-supermicro-x11spi.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dt.yaml
DTC arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dt.yaml
CHECK arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dt.yaml
next prev parent reply other threads:[~2021-11-03 16:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 20:37 [PATCH -next v2 0/6] Add LCLK control into Aspeed LPC sub drivers jae.hyun.yoo
2021-11-02 20:37 ` [PATCH -next v2 1/6] ARM: dts: aspeed: add LCLK setting into LPC IBT node jae.hyun.yoo
2021-11-02 20:37 ` [PATCH -next v2 2/6] dt-bindings: ipmi: bt-bmc: add 'clocks' as a required property jae.hyun.yoo
2021-11-02 20:37 ` [PATCH -next v2 3/6] ipmi: bt: add clock control logic jae.hyun.yoo
2021-11-02 20:37 ` [PATCH -next v2 4/6] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes jae.hyun.yoo
2021-11-02 20:37 ` [PATCH -next v2 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property jae.hyun.yoo
2021-11-03 1:20 ` Rob Herring
2021-11-03 1:52 ` Corey Minyard
2021-11-03 16:13 ` Jae Hyun Yoo
2021-11-03 16:08 ` Jae Hyun Yoo [this message]
2021-11-03 16:29 ` Rob Herring
2021-11-03 17:26 ` Jae Hyun Yoo
2021-11-03 22:45 ` Joel Stanley
2021-11-04 16:16 ` Jae Hyun Yoo
2021-11-02 20:37 ` [PATCH -next v2 6/6] ipmi: kcs_bmc_aspeed: add clock control logic jae.hyun.yoo
2021-11-03 0:59 ` [PATCH -next v2 0/6] Add LCLK control into Aspeed LPC sub drivers Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8db279c9-4c76-91a5-3617-a17effb2d103@linux.intel.com \
--to=jae.hyun.yoo@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=chiawei_wang@aspeedtech.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=haiyue.wang@linux.intel.com \
--cc=jae.hyun.yoo@intel.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).