From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH] of: Delete an unnecessary check before the function call "of_node_put" Date: Tue, 19 Jul 2016 22:52:12 +0200 Message-ID: <8db62ad3-2e8a-327e-30a8-594f628cd8be@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5317A59D.4@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org To: devicetree@vger.kernel.org, Frank Rowand , Rob Herring Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: devicetree@vger.kernel.org From: Markus Elfring Date: Tue, 19 Jul 2016 22:42:22 +0200 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/of/base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index a4b6087..2601167 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -1609,8 +1609,7 @@ static int __of_parse_phandle_with_args(const struct device_node *np, */ err: - if (it.node) - of_node_put(it.node); + of_node_put(it.node); return rc; } -- 2.9.2