From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Sibi Sankar <quic_sibis@quicinc.com>,
andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: agross@kernel.org, conor+dt@kernel.org, quic_tdas@quicinc.com,
quic_rjendra@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, neil.armstrong@linaro.org,
abel.vesa@linaro.org, quic_tsoni@quicinc.com
Subject: Re: [PATCH 2/4] clk: qcom: Add Global Clock controller (GCC) driver for SC8380XP
Date: Thu, 26 Oct 2023 13:06:54 +0200 [thread overview]
Message-ID: <8dc48acb-46f0-47fa-bf7f-ee2d09eebcb3@linaro.org> (raw)
In-Reply-To: <20231025133320.4720-3-quic_sibis@quicinc.com>
On 10/25/23 15:33, Sibi Sankar wrote:
> From: Rajendra Nayak <quic_rjendra@quicinc.com>
>
> Add support for the global clock controller found on SC8380XP
> based devices.
>
> Co-developed-by: Abel Vesa <abel.vesa@linaro.org>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
[...]
> +static int gcc_sc8380xp_probe(struct platform_device *pdev)
> +{
> + struct regmap *regmap;
> + int ret;
> +
> + regmap = qcom_cc_map(pdev, &gcc_sc8380xp_desc);
> + if (IS_ERR(regmap))
> + return PTR_ERR(regmap);
> +
> + ret = qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks,
> + ARRAY_SIZE(gcc_dfs_clocks));
> + if (ret)
> + return ret;
> +
> + /*
> + * Keep the critical clock always-On
> + * gcc_camera_ahb_clk, gcc_camera_xo_clk, gcc_disp_ahb_clk,
> + * gcc_disp_xo_clk, gcc_gpu_cfg_ahb_clk, gcc_video_ahb_clk,
> + * gcc_video_xo_clk
> + */
> + regmap_update_bits(regmap, 0x26004, BIT(0), BIT(0));
Please inline the clock names, like so:
regmap_update_bits(regmap, 0x26004, BIT(0), BIT(0)); /* gcc_camera_ahb_clk */
LGTM otherwise
Konrad
next prev parent reply other threads:[~2023-10-26 11:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 13:33 [PATCH 0/4] clk: qcom: Introduce clocks drivers for SC8380XP Sibi Sankar
2023-10-25 13:33 ` [PATCH 1/4] dt-bindings: clock: qcom: Add SC8380XP GCC clocks Sibi Sankar
2023-10-27 8:20 ` Krzysztof Kozlowski
2023-10-25 13:33 ` [PATCH 2/4] clk: qcom: Add Global Clock controller (GCC) driver for SC8380XP Sibi Sankar
2023-10-25 16:40 ` Bryan O'Donoghue
2023-11-17 3:56 ` Sibi Sankar
2023-11-17 8:13 ` Johan Hovold
2023-11-17 14:24 ` Bryan O'Donoghue
2023-10-26 11:06 ` Konrad Dybcio [this message]
2023-10-27 8:21 ` Krzysztof Kozlowski
2023-10-25 13:33 ` [PATCH 3/4] dt-bindings: clock: qcom-rpmhcc: Add RPMHCC bindings " Sibi Sankar
2023-10-27 8:20 ` Krzysztof Kozlowski
2023-10-25 13:33 ` [PATCH 4/4] clk: qcom: rpmh: Add support for SC8380XP rpmh clocks Sibi Sankar
2023-10-25 20:38 ` Bryan O'Donoghue
2023-10-26 11:07 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dc48acb-46f0-47fa-bf7f-ee2d09eebcb3@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).