From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Robert Marko <robimarko@gmail.com>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm
Date: Mon, 7 Nov 2022 10:58:24 +0100 [thread overview]
Message-ID: <8dcc223d-48ab-f11d-5cc3-7fe129b9186d@linaro.org> (raw)
In-Reply-To: <20221107092930.33325-2-robimarko@gmail.com>
On 07/11/2022 10:29, Robert Marko wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
> harcoding the cell value.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
KOnrad
> arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> index 262b937e0bc6..651a231554e0 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> @@ -5,6 +5,7 @@
> /dts-v1/;
>
> #include "ipq8074.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> aliases {
> @@ -39,12 +40,12 @@ &blsp1_uart5 {
>
> &pcie0 {
> status = "okay";
> - perst-gpios = <&tlmm 58 0x1>;
> + perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
> };
>
> &pcie1 {
> status = "okay";
> - perst-gpios = <&tlmm 61 0x1>;
> + perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
> };
>
> &pcie_phy0 {
next prev parent reply other threads:[~2022-11-07 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 9:29 [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" Robert Marko
2022-11-07 9:29 ` [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm Robert Marko
2022-11-07 9:58 ` Konrad Dybcio [this message]
2022-11-07 9:58 ` Konrad Dybcio
2022-11-07 10:31 ` Krzysztof Kozlowski
2022-11-07 9:29 ` [PATCH 3/3] arm64: dts: qcom: hk01: " Robert Marko
2022-11-07 9:58 ` Konrad Dybcio
2022-11-07 10:31 ` Krzysztof Kozlowski
2022-11-07 9:53 ` [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" Konrad Dybcio
2022-11-07 10:31 ` Krzysztof Kozlowski
2022-11-08 1:27 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dcc223d-48ab-f11d-5cc3-7fe129b9186d@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).